Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation when moving a post to the trash #19125

Closed
mrfoxtalbot opened this issue Dec 13, 2019 · 6 comments · Fixed by #50219
Closed

Ask for confirmation when moving a post to the trash #19125

mrfoxtalbot opened this issue Dec 13, 2019 · 6 comments · Fixed by #50219
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Dec 13, 2019

Gutenberg will not ask for confirmation when clicking on the "Move to Trash Button", making it easy for a user to delete a post accidentally.

The "1 post sent to the Trash." message that appears after this is not too visible either.

Describe the solution you'd like
I think we need an intermediate step to make sure users did not click on the "Move to Trash" button by accident.

Describe alternatives you've considered
I would like to see a confirmation message, asking the user to confirm that the indeed wat to delete that post. Something like this.

@gziolo gziolo added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Dec 14, 2019
@MichaelArestad MichaelArestad added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Dec 17, 2019
@MichaelArestad
Copy link
Contributor

Hey! Thanks for reporting this. This was discussed today in Slack. There's definitely room for improvement here.

The likely solution is similar to what you proposed with a secondary confirmation step of some sort.

That said, I believe this is a lower priority right now for a couple reasons. It's an action that can be undone. It's fairly obvious when it happens as the user is directed away from the editor to Posts or Pages.

Again, this is definitely a flow with room for improvement, but we have limited design resources to tackle this at the moment so we need to prioritize our efforts.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Apr 14, 2020
@richtabor
Copy link
Member

What if we did a double-click to verify, like in this Figma prototype?

Screen Shot 2020-06-04 at 12 34 39 PM

@mrfoxtalbot
Copy link
Author

I love that idea @richtabor!

@MichaelArestad
Copy link
Contributor

Works for me!

@jodamo5
Copy link
Contributor

jodamo5 commented Dec 30, 2020

I'd definitely like this confirmation button to be added. On my Wordpress installation, for some reason the "Move to Trash" button appears about 1 sec after the rest of the page has loaded. I tried to click on "Revisions" but just as I did the "Move to Trash" button appeared, pushing the Revisions button down inadvertently causing the post to be moved to trash. I've also had a client who accidentally moved a post to trash without realising. A confirmation step would be very useful.

@kimclowa8c
Copy link

I'd love for this request to get some traction again!

I put in a new feature request before I saw this over on the Calypso repo: Automattic/wp-calypso#70755

I've closed that issue to work over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants