Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich text blocks: add new link interface #19270

Closed
karmatosed opened this issue Dec 20, 2019 · 3 comments · Fixed by #19462
Closed

Rich text blocks: add new link interface #19270

karmatosed opened this issue Dec 20, 2019 · 3 comments · Fixed by #19462
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

karmatosed commented Dec 20, 2019 •
edited
Loading

Currently, paragraph block looks like this:

image

It would be good to bring in the new link interface from navigation:

link

This should be done across all rich text blocks, for example, quote, heading, paragraph and quote.
@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts [Block] Paragraph Affects the Paragraph Block labels Dec 20, 2019
@karmatosed karmatosed changed the title Add new link interface to paragraph block Paragraph block: add new link interface Dec 20, 2019
@karmatosed karmatosed changed the title Paragraph block: add new link interface Rich text blocks: add new link interface Dec 20, 2019
@karmatosed karmatosed mentioned this issue Dec 20, 2019
Closed
@karmatosed karmatosed added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable and removed [Block] Paragraph Affects the Paragraph Block labels Dec 20, 2019
@youknowriad youknowriad mentioned this issue Jan 17, 2020
Merged
@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 31, 2020 •
edited
Loading

Btw after choosing a link and clicking enter the next step is seeing the option to open in new tab:

Screen Shot 2020-01-31 at 12 24 51

I just wanted to show the option in how to open in a new tab is implemented in the new link interface.

@karmatosed
Copy link
Member Author

karmatosed commented Feb 3, 2020 •
edited
Loading

@paaljoachim thanks for sharing that image.

Just to check, are you suggesting it should be iterated or just showing the implementation? If you are interested in exploring other options an issue might be best to do that in so we can get the link interface the same across all interfaces and then iterate.

@aduth aduth mentioned this issue Feb 3, 2020
Closed
@paaljoachim
Copy link
Contributor

Hey Tammie. @karmatosed I was just showing the implementation of how Open in new tab has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Dev Ready for, and needs developer efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try the link control in the link format WordPress/gutenberg
2 participants
@karmatosed @paaljoachim