Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Bug: Select tool does not always select the correct layer #19454

Closed
jasmussen opened this issue Jan 7, 2020 · 6 comments
Closed

Safari Bug: Select tool does not always select the correct layer #19454

jasmussen opened this issue Jan 7, 2020 · 6 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

The select tool (press Escape, or choose from the toolbar) selects the layers of a block parent first. Click a columns block and you select the columns block itself, then the column, then contents inside that column. This is the inverse behavior of the default tool, where you click to edit text directly.

In Safari this behavior is slightly buggy in that the selection is not instantly reset when you click outside a block to deselect. Observe Safari:

safari

Note how when I've clicked through to the Paragraph layer, then deselect the block and quickly select it again, I can select the Paragraph again, even though the selection index should have been reset. It does get reset after a delay, but it is not instant.

Here's Chrome:

chrome

Note how regardless of which layer I select, when I deselect the block the selection index is immediately reset, as it should be.

The issue appears to be related to the BlockAsyncRenderProvider.

@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Jan 7, 2020
@momotofu
Copy link
Contributor

I was also able to reproduce this bug on Safari Version 13.0.4

@paaljoachim
Copy link
Contributor

Testing using:
WordPress 5.7
Twenty Twenty One.
Gutenberg plugin 10.4
Safari

I tested similar to what @jasmussen Joen mentioned and to me it now seems to be working correctly.
As parent block is selected I can click directly into the paragraph block inside the columns block.
I believe this issue can now be closed.

@jasmussen
Copy link
Contributor Author

@gziolo in relation to #30299, should this one or that be closed? Are they the same do you know? Thanks for testing Paal.

@gziolo
Copy link
Member

gziolo commented Apr 16, 2021

It's very likely they are the same, see my comment: #30299 (comment). There is also #29678 that looks similar. Ideally, we test them all and close all that can't be reproduced. @jasmussen, can you still reproduce this one?

@Mamaduka
Copy link
Member

There's also #30249, which I could reproduce on Chrome, but it's inconsistent compared to Safari.

Unfortunately, I'm not sure where to look next for the source of the issue.

@ellatrix
Copy link
Member

Should be fixed after #30995. Please reopen if that's not the case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants