Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Update react-native-video dependency to remove Apache 2.0 dependencies #19860

Closed
Tug opened this issue Jan 24, 2020 · 1 comment · Fixed by wordpress-mobile/gutenberg-mobile#2124
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Comments

@Tug
Copy link
Contributor

Tug commented Jan 24, 2020

This is part of the Monorepo effort (see #18508).

Some of the dependencies gutenberg-mobile currently have are not compatible with GPLv2. We need to fork and update the one that are bundled/distributed. We can keep the ones that are involved in the build process, but we should make sure those are devDependencies.

We have identified the following dependencies that will need to be rewritten:

gutenberg@7.2.0
├─┬ @wordpress/react-native-editor@1.20.0
│ └─┬ react-native-video@4.4.1
│   ├── keymirror@0.1.1                <- Apache 2.0 license
│   └── shaka-player@2.5.8             <- Apache 2.0 license
@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 24, 2020
@dratwas dratwas mentioned this issue Feb 3, 2020
21 tasks
@maxme
Copy link
Contributor

maxme commented Feb 6, 2020

I opened a PR to remove keymirror and shaka-player from our fork of react-native-video: wordpress-mobile/react-native-video#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
2 participants