Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental block directory search does not show blocks when plugin deactivated #19906

Closed
bobbingwide opened this issue Jan 27, 2020 · 4 comments
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Type] Bug An existing feature does not function as intended

Comments

@bobbingwide
Copy link
Contributor

bobbingwide commented Jan 27, 2020

Describe the bug
I was testing the Experimental Block directory search in my development environment and was unable to find the boxer block. Analysis of the response from wordpress.org indicated that the block / plugin was returned in the list. But the plugin was already installed so was excluded from the results returned to the browser. The plugin was already installed; but it was deactivated.

To reproduce
Steps to reproduce the behavior:

  1. Install boxer block plugin but don’t activate it
  2. Enable Block Directory experiment
  3. Add new post
  4. Open block inserter and search for boxer
  5. Find it’s not listed.

Expected behavior
I should be offered the opportunity to activate the plugin.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6] iPad
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari] Safari
  • Version [e.g. 22]

Additional context
Gutenberg 7.3.0
Problem occurs on WordPress and Multi Site.

@talldan talldan added [Feature] Block Directory Related to the Block Directory, a repository of block plugins Needs Testing Needs further testing to be confirmed. labels Feb 6, 2020
@annezazu
Copy link
Contributor

Thanks for reporting this. It's a great find. I was able to replicate it in my testing! It seems the block directory doesn't handle cases where a plugin is installed on the site but is inactive. It only works if the block plugin is installed and active OR if the plugin isn't installed at all.

@annezazu annezazu added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Apr 23, 2020
@StevenDufresne
Copy link
Contributor

Related:

#15121 (comment)

See second bullet point.

@StevenDufresne
Copy link
Contributor

@bobbingwide We merged #22286 to address this issue. More information can be found within the ticket :)

Thanks for the ticket!

@bobbingwide
Copy link
Contributor Author

It seems the recent updates for #22454 have (intentionally) broken the fix in #22286.
The new issue is #23570.
See the Block directory issue ( #23378 ) for the list of issues that are needed for the block directory to make it into 5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants