Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: Post Title: Title should be editable #21663

Closed
aduth opened this issue Apr 16, 2020 · 2 comments
Closed

Block Library: Post Title: Title should be editable #21663

aduth opened this issue Apr 16, 2020 · 2 comments
Labels
[Block] Post Title Affects the Post Title Block [Package] Block library /packages/block-library [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Apr 16, 2020

Previously: #21467 (#21467 (comment)), #19572

Context:

#21467 made minimal enhancements to the Post Title block to show a live title of the post. Ideally, this title block should be editable and mirror to and from the corresponding post entity.

There is prior art in #19572 for this, where the title was implemented as RichText.

Task:

Implement an editable field for the Post Title block.

Implementation Specifics:

The title inherits many of the same behaviors of a heading block, and may warrant some refactoring to better support a feature parity.

See also:

@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block library /packages/block-library [Block] Post Title Affects the Post Title Block labels Apr 16, 2020
@mtias
Copy link
Member

mtias commented Apr 29, 2020

The title inherits many of the same behaviors of a heading block, and may warrant some refactoring to better support a feature parity.

Consider for editing, in most cases, those attributes would be locked (like the current post title ad hoc component we have in the main editor). When users are writing a post, they should be interacting with the title block, but they should not be able to change the heading level, etc, since they are not editing the template.

@ntsekouras
Copy link
Contributor

ntsekouras commented Mar 29, 2021

Implemented here: #27240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Package] Block library /packages/block-library [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants