Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Tab to access block toolbar doesn't work in Safari #22598

Closed
ZebulanStanphill opened this issue May 25, 2020 · 5 comments
Closed

Shift+Tab to access block toolbar doesn't work in Safari #22598

ZebulanStanphill opened this issue May 25, 2020 · 5 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented May 25, 2020

The issue

On Safari, pressing Shift-Tab to move focus from the block content to the block toolbar doesn't work. Instead, the address bar of the browser is focused.

How to reproduce

  1. Open the block editor in Safari.
  2. Create a Paragraph block (or some other basic text block).
  3. Focus the content of the block.
  4. Press Shift+Tab.
  5. Notice that the address bar is focused, not the block toolbar like you would expect.

Additional info

Tested on master as of 7f797a6. I don't know when this regressed, but I suspect it may have started with #20008.

@ZebulanStanphill ZebulanStanphill added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [a11y] Keyboard & Focus labels May 25, 2020
@youknowriad youknowriad added the Browser Issues Issues or PRs that are related to browser specific problems label May 25, 2020
@ZebulanStanphill ZebulanStanphill changed the title Shift-Tab to access block toolbar doesn't work in Safari Shift+Tab to access block toolbar doesn't work in Safari May 25, 2020
@enriquesanchez
Copy link
Contributor

Hi @ZebulanStanphill!

Does this only happen on Safari? Could it maybe be related to #22434?

@ZebulanStanphill
Copy link
Member Author

I tested: it doesn't happen on Firefox, nor does it happen on Chrome. (I tested both on macOS.) The inserter was not open in my tests, so I don't think it's related.

@enriquesanchez
Copy link
Contributor

Hey @ZebulanStanphill 👋

I can't reproduce on Safari, running tip of master:

2020-05-28 14-59-39 2020-05-28 15_00_54

@mcsf mcsf added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 3, 2020
@ZebulanStanphill
Copy link
Member Author

This is still happening to me. Tested in Safari 13.1 on macOS Catalina 10.15.4 using Gutenberg master as of ed80299.

@ZebulanStanphill ZebulanStanphill removed the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 6, 2020
@ZebulanStanphill
Copy link
Member Author

ZebulanStanphill commented Jun 12, 2020

I just discovered that this isn't a bug. It's just standard default behavior in Safari.

Tab highlights the next text field or pop-up menu. Tab also highlights buttons and other controls if “All controls” is selected in the Shortcuts pane of the Keyboard pane of System Preferences.

Option-Tab highlights the same items as Tab plus all other clickable items.

To swap the behavior of Tab and Option-Tab, turn on “Press Tab to highlight each item on a webpage” in the Advanced pane of Safari preferences.

In other words, you have to use Shift+Option+Tab to achieve the same thing in Safari as Shift+Tab in other browsers, unless you change Safari settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

4 participants