Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching between Edit Navigation and Manage Locations tab resets menu selection #22625

Closed
manmotive opened this issue May 26, 2020 · 4 comments
Closed

Switching between Edit Navigation and Manage Locations tab resets menu selection #22625

manmotive opened this issue May 26, 2020 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@manmotive
Copy link

Describe the bug
Switching between Edit Navigation and Manage Locations tab resets menu selection

To reproduce
Steps to reproduce the behavior:

  1. Go to the new Navigation page
  2. Select a different menu from the default one from the menu selector
  3. Switch to the Manage Locations tab
  4. Switch back to the Edit Navigation tab
  5. The selected menu will revert back to the default (rather than the one selected in step 2)

Expected behavior
The previously selected menu remains selected
@talldan talldan added [Feature] Navigation Screen Needs Testing Needs further testing to be confirmed. labels Jun 3, 2020
@talldan
Copy link
Contributor

talldan commented Jun 3, 2020

Sounds similar to #22340

@talldan talldan mentioned this issue Jun 3, 2020
Closed
@draganescu
Copy link
Contributor

I think this is different from #22340 . The latter one is fixed by #22428 by using the correct operations to delete an entity. This here needs the selected menu state higher in the tree.

@talldan talldan mentioned this issue Jun 16, 2020
Merged
6 tasks
@annezazu annezazu added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Jun 30, 2020
@annezazu
Copy link
Contributor

Just nothing that I replicated this with Gutenberg 8.4.0 and WordPress 5.4.2. Changed to a bug rather than needing testing :)

@talldan
Copy link
Contributor

talldan commented Jan 29, 2021

Closing as the design has now changed. Manage Locations is now in a dropdown which resolves this issue.

@talldan talldan closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@draganescu @talldan @annezazu @manmotive