Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Navigation screen ] Improve auto focus to make "go to" consistent for nested blocks #23269

Closed
draganescu opened this issue Jun 18, 2020 · 1 comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality

Comments

@draganescu
Copy link
Contributor

draganescu commented Jun 18, 2020

Incoming once #22996 is merged we need to remove the selection using a call in this form:

await selectEditorBlock( null );

This is required because Block List immediately applies focus when isSelected changes. Given we need to prevent this maybe there is a way to improve how preventing it works and update the effect here:

useEffect( () => {
if ( ! isMultiSelecting && ! isNavigationMode && isSelected ) {
focusTabbable();
}
}, [ isSelected, isMultiSelecting, isNavigationMode ] );

It's not clear yet if it is really a problem. It may be that the same problem here is causing this:

select-nested

@draganescu draganescu added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Code Quality Issues or PRs that relate to code quality [Feature] Navigation Screen labels Jun 18, 2020
@draganescu draganescu added [Type] Bug An existing feature does not function as intended and removed [Type] Task Issues or PRs that have been broken down into an individual action to take labels Jun 19, 2020
@draganescu draganescu changed the title [ Navigation screen ] Explore improving auto focus [ Navigation screen ] Improve auto focus to make "go to" consistent for nested blocks Jun 19, 2020
@talldan
Copy link
Contributor

talldan commented Jan 29, 2021

@draganescu Was this fixed by #25322? I'll close it, but feel free to reopen.

@talldan talldan closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

2 participants