Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to specify the version a function was deprecated #23373

Closed
desrosj opened this issue Jun 22, 2020 · 1 comment · Fixed by #30017
Closed

Add ability to specify the version a function was deprecated #23373

desrosj opened this issue Jun 22, 2020 · 1 comment · Fixed by #30017
Assignees
@Mamaduka
Labels
[Package] Deprecated packages/deprecated [Status] In Progress Tracking issues with work in progress

Comments

@desrosj
Copy link
Contributor

desrosj commented Jun 22, 2020

In some cases, it is desirable to indicate the version that a function was deprecated.

For example, a function was deprecated in Core changeset 48121. For WordPress Core, this function will need to remain for quite a while for backwards compatibility, so the current version parameter does not work, as specifying it will output and will be removed from WordPress in x.x.x.

It would be nice if there was also an option to specify the deprecated version to output something like was deprecated in x.x.x and will be removed in y.y.y, where both are optional.
@desrosj desrosj added the [Package] Deprecated packages/deprecated label Jun 22, 2020
@Mamaduka
Copy link
Member

This would be really nice extra information to have in logs.

Now it takes time to track down Gutenberg/WordPress version when the component or method was deprecated.

Question: Should "since" point to a Gutenberg plugin version or a WP version?

Mamaduka added a commit to Mamaduka/gutenberg that referenced this issue Mar 19, 2021
@Mamaduka
Add 'since' option to deprecated function
568afc3 
See WordPress#23373.
@Mamaduka Mamaduka mentioned this issue Mar 19, 2021
Merged
4 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 19, 2021
gziolo pushed a commit that referenced this issue Mar 19, 2021
@Mamaduka
Add 'since' option to deprecated function (#30017)
a4b2b42 
* Add 'since' option to deprecated function

See #23373.

* Fixes formatting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Package] Deprecated packages/deprecated [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated: Add since option to deprecated function Mamaduka/gutenberg
2 participants
@Mamaduka @desrosj