Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-percent values to be used for column-width #24193

Closed
aristath opened this issue Jul 24, 2020 · 1 comment
Closed

Allow non-percent values to be used for column-width #24193

aristath opened this issue Jul 24, 2020 · 1 comment
Labels
[Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement.

Comments

@aristath
Copy link
Member

aristath commented Jul 24, 2020

When building a FSE template, themes, designers & authors will need a lot more than just % values.
The simplest and most common scenario: A header with a 200px-wide column on the left for the logo while the menu is on the right and takes up the remaining available space. Percent values won't do 'cause we don't want the logo to shrink.
Ideally we'd have something like #18600, but since that idea never took off, we're forced to try and build things using nothing but group and column blocks.
We'll need something more versatile than hardcoded % values.

A possible solution would be to add a "custom" switch next to the current width controls we have in columns. If selected, it would show a textfield where users can enter what they need.
A numeric field with a units-selector next to it like it's being discussed for some global styles will do for most cases but probably won't cover things like calc(100% - 200px).

@talldan talldan added [Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement. labels Jul 28, 2020
@aristath
Copy link
Member Author

aristath commented Feb 8, 2021

Fixed in #24711

@aristath aristath closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants