Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview menu: arrows navigation doesn't work #24453

Closed
afercia opened this issue Aug 9, 2020 · 1 comment · Fixed by #24465
Closed

Preview menu: arrows navigation doesn't work #24453

afercia opened this issue Aug 9, 2020 · 1 comment · Fixed by #24465
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Aug 9, 2020

Describe the bug
The WordPress 5.5 block editor will ship with a new "Preview" menu with options for desktop, tablet, mobile, and traditional preview in a new browser tab. Since it's an ARIA menu and looks like other menus where arrows navigation works, I'd expect arrows navigation to work on this menu as well. It doesn't.

To reproduce

  • edit a post
  • use the keyboard
  • tab to the Preview menu button
  • press Enter to open the menu
  • the menu opens and focus is moved to the first menu item: so far so good
  • use the Down and Up arrow keys to try to navigate through the menu items
  • nothing happens

Additionally:

  • open your browser's dev tools or shrink the browser's window height so that the page has some scrolling
  • observe that while using the arrow keys on the menu items, the page (see the admin menu) scrolls, which means the default action is not prevented

Animated GIF:

preview menu arrowing

Expected behavior
Arrows navigation on the Preview menu items to work and the default action to be prevented.

Editor version (please complete the following information):

  • WordPress version: 5.5 Beta 2
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Tested both
  • If the Gutenberg plugin is installed, which version is it? 8.7.0 latest master

Noting that, technically, this is not a regression but it's a new feature introduced in WordPress that doesn't meet the expected accessibility best practices.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Aug 9, 2020
@ntsekouras ntsekouras self-assigned this Aug 10, 2020
@ntsekouras
Copy link
Contributor

Thanks for reporting this @afercia!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants