Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Technical or Documentation Support for "Hero" or "Cover Block" Header Patterns #24634

Closed
ianstewart opened this issue Aug 18, 2020 · 2 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Developer Documentation Documentation for developers

Comments

@ianstewart
Copy link
Contributor

ianstewart commented Aug 18, 2020

This feature request, related to block patterns, template parts, and block-based-theming may not require a technical solution. Here are the options I see as possible solutions …

  1. A technical block-level solution.
  2. Documentation in a handbook for this scenario as a "you might try this!" sort of thing. (For now.)
  3. Accounting for user flows in the Site Editor and Post/Page Editors.

Here's the feature request. Support for the following "Header Pattern".

image

  • On the left is the front page of a WordPress site loading a header-front-page.html template part. - On the right is a page on that site loading a header-page.html template part.
  • Peeking over the edge of the page on the right is my text editor with the theme structure supporting that. I thought it'd be useful.

Everything with a blue background is the "header". Here are some perhaps unusual features of these template parts.

Both of these template parts use cover blocks. Here's a screenshot of one with the Detective Wapuu extension doing it's thing.

image

It's becoming more and more common to see Header Patterns like this. With what we think of as the Header of a site over top of a "hero section" that feels like "part of the page." It's especially common to see this pattern with an image or even a video in the background.

Here's a picture with a picture.

image

Also perhaps somewhat unusual, in the page on the right. The header template part has the post title inside the header, not the page content. I could envision scenarios where this might seem strange for a user.

Why? This was the only way I could currently think of to achieve this type of header pattern with a block-based theme. Which leads me to my list at the start of this issue.

  1. Should there be some sort of technical block-level solution for this type of pattern?
  2. If not, should there be documentation in a handbook for this scenario as a "you might try this!" sort of thing. (For now.)
  3. Either way we should perhaps make sure there is an accounting for user flows around this in the Site Editor and Post/Page Editors.

Possibly related issue: #16281

@ianstewart ianstewart changed the title Feature Request: Technical or Documentation Support for Feature Request: Technical or Documentation Support for "Hero" or "Cover Block" Header Patterns Aug 18, 2020
@jorgefilipecosta jorgefilipecosta added the [Type] Developer Documentation Documentation for developers label Aug 19, 2020
@kjellr kjellr added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels Aug 19, 2020
@DaisyOlsen
Copy link
Contributor

@ianstewart It's been a minute or two since you posted this idea. Do you think it would still be necessary to document this specifically? It seemed pretty simple to create this in a template part with minimal fuss at this point with all the improvements since the time this issue was opened.

@DaisyOlsen
Copy link
Contributor

Confirmed with @ianstewart that it's fine to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

No branches or pull requests

4 participants