Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movers: description text for horizontal movement is incorrect with multiple selection #25158

Closed
afercia opened this issue Sep 8, 2020 · 1 comment · Fixed by #42393
Closed
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Sep 8, 2020

Describe the bug
Noticed while working on #24894

Some blocks can be moved horizontally, for example the buttons in the "Buttons" block and the Social icons.

In this case, the mover buttons aria-label (and tooltip) correctly says "Move right" or "Move left" instead of down and up.

However, there's also some descriptive text used for the aria-describedby attribute that provides more info on the position etc. This descriptive text is correct when there's only one block selected. See in the screenshot below, with just one button selected the text is: "Move Button block from position 1 right to position 2":

Screenshot 2020-09-08 at 17 12 15

Instead, the text is not correct when there's more than one block selected. See in the screenshot below, with two buttons selected the text is: "Move 2 blocks from position 1 down by one place":

Screenshot 2020-09-08 at 17 10 47

Where "down" is wrong and it should be "right".

Similarly, when moving to left. There's some logic in place to build these strings and it should be reviewed. Also, checking what happens with RTL languages is important.

Editor version (please complete the following information):

  • WordPress version: 5.6 trunk
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? both
  • If the Gutenberg plugin is installed, which version is it? 8.9.2
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 8, 2020
@talldan talldan added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 19, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 30, 2021
@thisissandip
Copy link
Contributor

PR added: #32337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
5 participants