Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal point picker drag handle sets incorrect coordinates in macOS Safari #25814

Closed
ghost opened this issue Oct 4, 2020 · 4 comments · Fixed by #28096
Closed

Focal point picker drag handle sets incorrect coordinates in macOS Safari #25814

ghost opened this issue Oct 4, 2020 · 4 comments · Fixed by #28096
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended

Comments

@ghost
Copy link

ghost commented Oct 4, 2020

Describe the bug
When using macOS Safari and attempting to set a focal point for Cover Block media via the drag handle, it incorrectly sets the coordinates to (0, 0) regardless of where you drag your cursor.

To reproduce
Steps to reproduce the behavior:

  1. Navigate to create a new post.
  2. Add a Cover Block.
  3. Set the media for the Cover Block.
  4. Click the Cover Block to reveal the media settings in the right sidebar.
  5. Click and drag within the "Focal point picker" media settings section.
  6. Focal point coordinates are set to (0, 0) regardless of where you drag your cursor.

Expected behavior
The focal point is correctly updated as you drag. The "Left" and "Top" input fields display the correct X and Y coordinates to match the position of your drag. The Cover Block rendering updates accordingly to position the media relative to the focal point coordinates.

Screenshots

Safari Chrome
focal-point-picker-safari focal-point-picker-chrome

Editor version (please complete the following information):

  • WordPress version: WordPress.com
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? n/a
  • If the Gutenberg plugin is installed, which version is it? n/a

Desktop (please complete the following information):

  • OS: macOS 10.15.6
  • Browser: Safari
  • Version: 14.0

Additional context

  • This behavior does not occur while using macOS Chrome.
@ghost ghost changed the title Focal point picker drag handle sets incorrect coordinates Focal point picker drag handle sets incorrect coordinates in macOS Safari Oct 4, 2020
@geriux geriux added the [Type] Bug An existing feature does not function as intended label Oct 5, 2020
@tellthemachines
Copy link
Contributor

I can only reproduce this intermittently on Safari, with Gutenberg 9.1. I haven't been able to repro with latest master. It only seems to happen when clicking anywhere on the image outside of the picker. Picking up and dragging the picker works fine.

@haszari
Copy link
Contributor

haszari commented Nov 24, 2020

I can reproduce this every time in Safari with latest Gutenberg plugin (9.4.1), or with WordPress 5.6 RC1. This is pretty frustrating, can't drag a focal point in Safari!

Screen Capture on 2020-11-24 at 13-07-57

Seems fine in Firefox and Chrome.

@youknowriad
Copy link
Contributor

I can reproduce this one consistently as well.

@youknowriad youknowriad added the Browser Issues Issues or PRs that are related to browser specific problems label Jan 11, 2021
@ItsJonQ
Copy link

ItsJonQ commented Jan 11, 2021

I just created a PR for the disappearing Focal Point UI.
Will look into the Safari interaction issues 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants