Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets Screen] Allow for a holistic Preview option #26182

Closed
annezazu opened this issue Oct 16, 2020 · 7 comments
Closed

[Widgets Screen] Allow for a holistic Preview option #26182

annezazu opened this issue Oct 16, 2020 · 7 comments
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Right now, one can individually preview legacy blocks in the Widgets Screen but if you want to see the entire section previewed with a mix of legacy widgets and blocks, you can't unless you individually preview each legacy widget.

Describe the solution you'd like

I'd love an option to preview in one fell swoop without having to update the widgets screen and seeing what it looks like. Similar to the flow with previewing a post, it would be great to have this option especially with the customizer flow unable to work with blocks in a way that one might usually preview changes to the widgets.

Here's a hacky design stolen from the preview button you see when adding a new post:

Screen Shot 2020-10-15 at 6 30 57 PM

I would expect when clicking on this that it would automatically show the preview for every legacy widget alongside the blocks.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Oct 16, 2020
@annezazu
Copy link
Contributor Author

For even more feedback on this, here's a copy and paste from here (props @garretthyder ) https://make.wordpress.org/core/2020/09/30/call-for-testing-the-widgets-screen-in-gutenberg-9-1/#comment-40072

It would be nice to introduce a preview capability to the sidebar sections as a whole so you can preview the entire sidebar to see how the widgets interact visually without having to click each one’s Preview individually. Ideally, once the widget form is filled in, I’d like it so that the widget defaults to the Preview mode when unselected. This would provide more of a Gutenberg feel. It would be nice to either default the widget blocks to preview mode, or provide a preview ability to view ALL blocks in preview.

@paaljoachim
Copy link
Contributor

I think it is a very good idea to use the preview button which would then automatically shift all widgets over to a preview mode.

@paaljoachim
Copy link
Contributor

Hey @annezazu
@enriquesanchez opened this issue 11 days ago: #25960 which is very similar to the issue you made here. The question becomes should we close the issue you opened and continue discussion in 25960?

@annezazu
Copy link
Contributor Author

I think the two issues are a bit separate. One is about the general, individual block preview behavior whereas this is about being able to preview everything at once. I don't feel strongly though so happy to have this closed if it's better!

@enriquesanchez
Copy link
Contributor

@paaljoachim @annezazu Agreed that these two are related but separate issues. I think both should remain open.

@mapk
Copy link
Contributor

mapk commented Nov 9, 2020

As I mentioned in this comment, if we forced the Legacy Widget to show the preview state when unselected, it would resolve this issue as well. But the Legacy Widget would only show the Preview if there was enough info filled out in the widget's form to display the preview correctly.

@noisysocks
Copy link
Member

noisysocks commented Apr 19, 2021

I would very much like the Widgets screen to have an actual Preview button which opens the frontend of your site in a new tab with your unpublished changes. This can be implemented using Customizer changesets. See #26012.

It's a significant undertaking though and not something that I think is necessary for WordPress 5.8 given that we will be defaulting all of the Legacy Widget blocks to show a preview as @mapk says above. See #26179.

So, closing this as "maybe later" / "duplicate of #26012". Thanks for the discussion and ideas everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants