Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello Dolly plugin causes screen breakage #26219

Closed
annezazu opened this issue Oct 16, 2020 · 7 comments · Fixed by #30729
Closed

Hello Dolly plugin causes screen breakage #26219

annezazu opened this issue Oct 16, 2020 · 7 comments · Fixed by #30729
Assignees
@getsource
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Describe the bug

The text from Hello Dolly causes strange overlap with the new Widgets Screen and also creates a new pathway to scroll up/down. According to wp.org, the plugin is used on 800k+ sites and is managed by wp.org so reporting here to be safe :D

To reproduce
Steps to reproduce the behavior:

  1. Install and Activate Gutenberg and Hello Dolly.
  2. Head to Appearance > Widgets
  3. See hello dolly text hidden behind update button.
  4. Click into the top toolbar and scroll up/down to see more breakage.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

20s Video: https://cloudup.com/cMMxkpVqcb1

Screenshot: Screen Shot 2020-10-16 at 1 04 06 PM

Editor version (please complete the following information):

  • WordPress version: 5.5.1
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Gutenberg Plugin
  • If the Gutenberg plugin is installed, which version is it? 9.1.1

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 86.0.4240.75
@annezazu annezazu added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 16, 2020
@noisysocks
Copy link
Member

noisysocks commented Jan 6, 2021 •
edited
Loading

Let's do whatever the block editor does here to address this.

@draganescu draganescu changed the title [Widgets Screen] Hello Dolly plugin causes screen breakage Hello Dolly plugin causes screen breakage Feb 18, 2021
@draganescu draganescu mentioned this issue Feb 18, 2021
Closed
53 tasks
@getsource
Copy link
Member

getsource commented Apr 5, 2021 •
edited
Loading

It looks like this is currently accounted for with the editor within the Hello Dolly plugin itself, which is included with WordPress core.

That looks to happen here: https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/plugins/hello.php#L85

Thinking it'd make sense to do the same in that plugin for the new Widgets screen, in that case.

@getsource
Copy link
Member

The closest class I can find is .appearance_page_gutenberg-widgets.

This works in the Hello Dolly plugin:

	.block-editor-page #dolly,
	.appearance_page_gutenberg-widgets #dolly {
		display: none;
	}

@noisysocks Since the class has Gutenberg in the name, do you think it makes sense to make a ticket + path and add to core at this point, or should it get added on the Gutenberg side first?

If Gutenberg, I'm not completely sure where it should be -- packages/edit-widgets/src/style.scss, maybe?

@noisysocks
Copy link
Member

Is .block-editor-page a class that's added to the <body>? Maybe the widgets screen should add it. It is, after all, a page containing a block editor and nothing else.

@lukecarbis
Copy link
Contributor

lukecarbis commented Apr 8, 2021 •
edited
Loading

If we're going to start slowly phasing the Hello Dolly message out with display: none on any Gutenbergish pages… maybe it's time to reassess whether we still need it?

@noisysocks
Copy link
Member

That's probably a decision better suited for a future DevChat. I know there's some strong feelings (good and bad) in the project about Hello Dolly 😀

@getsource
Copy link
Member

Is .block-editor-page a class that's added to the <body>? Maybe the widgets screen should add it. It is, after all, a page containing a block editor and nothing else.

Yes, it is! I don't know if anything else targets it that might not be preferred to apply to the Widgets screen as well, but I like that idea.

@getsource getsource mentioned this issue Apr 12, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getsource getsource

Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Hello Dolly plugin text doesn't overlap the widgets screen UI getsource/gutenberg
4 participants
@noisysocks @getsource @lukecarbis @annezazu