Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Editor: Missing ellipses Options menu from topbar #27564

Closed
mapk opened this issue Dec 7, 2020 · 5 comments · Fixed by #31926
Closed

Widget Editor: Missing ellipses Options menu from topbar #27564

mapk opened this issue Dec 7, 2020 · 5 comments · Fixed by #31926
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress

Comments

@mapk
Copy link
Contributor

mapk commented Dec 7, 2020

Describe the bug
It appears the Options menu was removed from the Widget Editor.

Screen Shot 2020-12-07 at 1 33 47 PM

Expected behavior
There are items there that are still beneficial in this screen such as:

  • Copy all content
  • Help
  • Preferences

I'd also like to add a preference options for keeping the Inserter panel open after selecting a block as indicated here: #26223 (comment)
Before we can do that, can we add back the Options menu first?

@critterverse
Copy link
Contributor

Seconding this menu as important functionality to add for both of the Widget editors. Opened a companion issue for the Customizer Widgets screen in #30886!

@draganescu
Copy link
Contributor

I've drowned myself in questions thinking about this:

  • Which options will we still need for the screens? Does fullscreen make sense? Code editor should not be available. Help, welcome guide and keyboard shortcuts, maybe but would probably need their own edits.
  • Is that the best place for some of the options? For example, copy all content, must not copy widget areas, and if we copy all widgets and blocks from all areas, all at once, what do we do it for?
    • How do some of the options apply in the Customizer? Copy all content means something else there as one can only edit one widget area at a time. This suggests copy all content should default to copying all current widget area content in both places.
  • The prefferences are also different, e.g. we don't have a pre-publish checklist.

Should we dive in these before we add it? Or add it and incrementally fix the problems?

@critterverse
Copy link
Contributor

critterverse commented May 17, 2021

I would vote for starting with a condensed version of the ellipses menu that only contains a few relevant options. This would allow for a few important accessibility/usability options to start, and then more things could potentially be added later as needed. For example, what if it only contained these options for now?

ellipses-menu

Re: Preferences menu, I don't think we need the entire modal but it would be nice to include the option for containing the text cursor inside blocks that usually appears within the "blocks" submenu. I could see this option being extracted from the Preferences modal to appear inline with other options in the ellipses menu.

@talldan talldan self-assigned this May 18, 2021
@talldan
Copy link
Contributor

talldan commented May 18, 2021

@critterverse This sounds good. I think 'Show Icon Labels' and 'Block Manager' could also be useful. I can look into how easy they would be to implement.

If it's mostly just re-using existing components, what do you think about those two?

edit: don't worry about this, looked into it and it turned out those two options are complicated 👍

@talldan
Copy link
Contributor

talldan commented May 18, 2021

As part of this, I think we need a dedicated widget editor user support page for the 'Help' link. This is what the post editor links to:
https://wordpress.org/support/article/wordpress-editor/

Lots of the content there isn't relevant.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants