-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji script needs to be disabled/improved #2799
Comments
The emoji script will likely be around forever - Twemoji tends to update their assets very quickly after a new Emoji spec is released, which we can start using immediately for rendering purposes. OS support follows sporadically, and then relies on people actually performing the update. To take the most recent Emoji update as an example, the spec was released May 18, the Twemoji update came up May 24, Core update May 25. Android added support in Android 8.0, released August 21. Windows, iOS, and MacOS support will be sometime later this year. |
Okay, guess we should go for option 3 then, plus a fix on the exclude class in core. Still wondering if the script in general is fine in React, updating text nodes outside editable areas. Theoretically it could just see the nodes again as dirty, which would again trigger a change by the script, creating an infinite loop. |
Per chat, let's disable the script on the page to resolve both editable problems and React concerns. |
This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs. |
Issue Overview
The emoji script, which is enqueued on all front-end and admin pages, and replaces emoji with images in browsers that have poor support (Chrome still too apparently), both at page load but also on mutations, is not compatible with Gutenberg's
Editable
at the moment.Steps to Reproduce (for bugs)
Expected Behavior
Current Behavior
The opposite. :)
Possible Solution
Related Issues and/or PRs
The text was updated successfully, but these errors were encountered: