Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting a template should require user confirmation and/or offer an undo action #28194

Closed
jameskoster opened this issue Jan 14, 2021 · 3 comments
Closed

Reverting a template should require user confirmation and/or offer an undo action #28194

jameskoster opened this issue Jan 14, 2021 · 3 comments
Assignees
@david-szabo97
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@jameskoster
Copy link
Contributor

If a user has made substantial customisations to a template then reverting it could have significant ramifications for their site. This action should ask the user to confirm that they actually want to revert, or offer an undo option in case they revert by mistake. Perhaps it should have both :)
@jameskoster
Copy link
Contributor Author

Since reverting a template isn't quite as extreme as deleting one, I think a Snackbar confirmation with undo action will probably be adequate here.

Screenshot 2021-01-14 at 12 28 38

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Jan 14, 2021
@david-szabo97 david-szabo97 self-assigned this Mar 4, 2021
@david-szabo97
Copy link
Member

@jameskoster Is this safe to close? #28141 added an undo action in the snackbar.

@jameskoster
Copy link
Contributor Author

Yes 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-szabo97 david-szabo97

Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskoster @david-szabo97