Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting a reusable block from the inspector #28355

Closed
mtias opened this issue Jan 20, 2021 · 5 comments
Closed

Allow deleting a reusable block from the inspector #28355

mtias opened this issue Jan 20, 2021 · 5 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Jan 20, 2021

Right now the only way to manage reusable blocks is through the custom post type list view. This is generally fine, but it'd make sense to allow at least deleting an existing reusable block from the sidebar inspector and/or the ellipsis menu.

@mtias mtias added Needs Design Needs design efforts. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Jan 20, 2021
@talldan
Copy link
Contributor

talldan commented Jan 21, 2021

For the purposes of documenting, we used to have this option in the block settings menu, and then it was removed because it was considered too easy to use - #12791

I'm sure there are other ways to solve that problem, but that was considered the right solution at the time.

@mtias
Copy link
Member Author

mtias commented Jan 21, 2021

Right, I remember now :D

I think the main issue there was also the confusion between removing the block from the canvas and removing the block entirely. It still makes sense in the sidebar to me, probably with some extra written context on what it does.

@paaljoachim
Copy link
Contributor

What about bringing in the delete Reusable block back into the block settings menu?
User clicks to delete and a warning message shows up with a message: Click Yes to confirm that you want to delete the Reusable block. User clicks Yes and the block is removed. Having it in the block settings drop down menu brings it out of sight and at the same time available.

@mtias
Copy link
Member Author

mtias commented Feb 24, 2021

The problem there is that it coexists with the "remove block from canvas" and it can be really confusing what each does. By placing it in the inspector we can give better context and show it's a more destructive action.

@annezazu
Copy link
Contributor

Closing this out with the overall Patterns section now encompassing reusable blocks/synced patterns where you can delete with ease and this current issue around including a "manage my patterns" option likely being more feasible: #54475 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants