Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Improve developer messaging for invalid blocks #2837

Closed
aduth opened this issue Sep 29, 2017 · 0 comments
Closed

Validation: Improve developer messaging for invalid blocks #2837

aduth opened this issue Sep 29, 2017 · 0 comments
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Sep 29, 2017

Related: #2210, #2056, #1929

Prior to #2210, when a block was marked as invalid, a console message was logged explaining the difference between the expected and actual content. With the move to creating a formal tokenizing validator in #2210, this was temporarily dropped with the intention of being brought back. Alas, this has not yet been reimplemented, thus the creation of this issue.

Task: Potentially using the previous logging or an explored diff display as inspiration, add messaging when block validation fails. This can probably be added directly into isValidBlock with a condition on the current environment.

Workaround: You can add a breakpoint on each of the failing checks to see where validation is bailing:

In each case, the comments above should explain the reason for failure.

@aduth aduth added [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Task Issues or PRs that have been broken down into an individual action to take labels Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

1 participant