-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[widgets screen] Since 9.8.0 the widgets screen settings cog no longer opens/closes sidebar #28402
Comments
Immediately after submitting this, I managed to get the block sidebar panel up... it still seems super intermittent and I can't explain why it sometimes appears or disappears. I add a list block, and some items to the list, no sidebar. clicking cog did nothing clicking the cog settings icon now open/closed the sidebar It's almost like the state of the sidebar wasn't listening to the focused item for some reason. i.e. when you click on the widget area itself, the sidebar disappears, but if you click on a block, the sidebar should open (if the settings cog is set to show it). But for a while after updating, nothing I did would get the sidebar to open, but after adding some blocks, it seems to now open the sidebar appropriately. I had used an incognito window to test the behaviour reported above wasn't cookie/cache related. But it seems... ok now? Will report back as I continue to test. |
I only tested this with one paragraph block, and had initial trouble getting the sidebar to open. Once I clicked on the wheel, it seems to open automatically again on select. Next time I selected the Paragraph block, it wouldn't open automatically, almost like there is a show/noshow sidebar toggle on the wheel, instead of open automatically. I am not confident if I explained it right, so I made a little video If feels like intended behavior, though. |
Seems like #28044 broke this. Should just be an easy fix though.
|
Hey @kevin940726! Could I work on this one? And, also, sorry, since I'm the author of #28044 😓. |
@rafaelgalani Sure! That's perfectly fine :), everybody makes mistakes 😉. We should think how to prevent this from happening instead. Maybe adding some e2e tests would help? |
@kevin940726 Yes! |
@rafaelgalani: Thanks for volunteering! I'll assign you to this issue so that we know it's being worked on. Let me know if you want to be unassigned. |
@rafaelgalani It's up to you! It's not required to add those tests, just recommended :). Normally, we would try to add tests if there're corresponding regressions, but I totally understand that it might not be straightforward to add though. We can add them in another PR next time. |
I just had the time to give more attention to it now. But seems like #28732 already fixed it! |
Hi folks! I didn't know of this issue, and "accidentally" addressed it in #28732 (as mentioned by @rafaelgalani) as part of a similar fix on the site editor. |
Description
Since updating to Gutenberg version 9.8.0 which includes a temporary fix for blocks not being able to save on the widgets screen (see #27173), the block controls sidebar is no longer visible meaning there is no access to block-level settings for each block.
The settings cog button (traditionally in the top right hand corner on my screen) is visible, but pressing the button only changes the status of the button itself, it doesn't open (or, I guess, close) the block controls sidebar.
Step-by-step reproduction instructions
Install version 9.8.0 of Gutenberg plugin
WordPress version 5.6
Go to wp-admin/themes.php?page=gutenberg-widgets (Or Appearance > Widgets)
Select a block -- no block sidebar is visibible
Click Settings button (cog icon) -- no sidebar appears
Expected behaviour
When selecting a block being used on the widget screen, the block controls sidebar should open
Actual behaviour
When selecting a block being used on the widget screen, the block controls sidebar is not visible and pressing the settings button (cog icon) does not show it.
WordPress information
Device information
The text was updated successfully, but these errors were encountered: