-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill component throws state update warning #28478
Labels
[Type] Bug
An existing feature does not function as intended
Comments
glendaviesnz
added
the
[Type] Bug
An existing feature does not function as intended
label
Jan 25, 2021
@diegohaz do you have any thoughts on how to prevent this issue? I struggled to see an easy way to check if the component was still mounted before running the setState in Fill. |
9 tasks
We're also seeing this issue on our SlotFill usage. |
19 tasks
@glendaviesnz #30667 just got merged that should fix this. Do you want to try it and confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In some circumstances the bubbles-virtually fill throws a
Can't perform a React state update on an unmounted component.
warning at https://github.com/WordPress/gutenberg/blob/master/packages/components/src/slot-fill/bubbles-virtually/fill.js#L13.This warning can be seen when dragging an image out of the refactored gallery PR.
Step-by-step reproduction instructions
Expected behaviour
No react state update warnings
Actual behaviour
State update warning show
Screenshots or screen recording (optional)
The text was updated successfully, but these errors were encountered: