Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template part toolbar contains an input that's not keyboard accessible #28825

Closed
talldan opened this issue Feb 8, 2021 · 1 comment
Closed

Template part toolbar contains an input that's not keyboard accessible #28825

talldan opened this issue Feb 8, 2021 · 1 comment
Labels
[Block] Template Part Affects the Template Parts Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Feb 8, 2021 •
edited
Loading

Description

The following e2e test is failing (https://github.com/WordPress/gutenberg/runs/1852467249):

FAIL specs/experiments/document-settings.test.js (12.378 s)

Document Settings › when a template is selected from the navigation sidebar › and a template part is clicked in the template › should display the selected template part's name in the document header

    expect(jest.fn()).not.toHaveWarned(expected)

    Expected mock function not to be called but it was called with:
    ["Using custom components as toolbar controls is deprecated. Please use ToolbarItem or ToolbarButton components instead. See: https://developer.wordpress.org/block-editor/components/toolbar-button/#inside-blockcontrols"]

The test seems to have caught an actual bug, something in a toolbar hasn't been implemented using ToolbarItem, which is required for the toolbar's keyboard accessibility. The screenshot shows this, so it seems related to the template part toolbar:
document-settings-when-a-template-is-selected-from-the-navigation-sidebar-and-a-template-part-is-clicked-in-the-template-should-display-the-selected-template-parts-name-in-the-document-header-2021-02-08t06-46-53
@talldan talldan added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [a11y] Keyboard & Focus [Block] Template Part Affects the Template Parts Block labels Feb 8, 2021
@talldan talldan mentioned this issue Feb 8, 2021
Merged
6 tasks
@talldan talldan changed the title Template part toolbar bug causing e2e test failure. Template part toolbar contains an input that's not keyboard accessible Feb 11, 2021
@talldan talldan mentioned this issue Feb 23, 2021
Closed
@talldan
Copy link
Contributor Author

talldan commented Mar 30, 2021

Closing as the toolbar for template part no longer has an input (#27397 (comment))

@talldan talldan closed this as completed Mar 30, 2021
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Template Part Affects the Template Parts Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@talldan @priethor