Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSE: Add ability to set favicon #29578

Closed
annezazu opened this issue Mar 5, 2021 · 2 comments
Closed

FSE: Add ability to set favicon #29578

annezazu opened this issue Mar 5, 2021 · 2 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Mar 5, 2021

What problem does this address?

As part of the second FSE call for testing, the ability to set a site's favicon was raised as currently this is set using the Customizer. With FSE, there seems to not currently be a way to set this up!

What is your proposed solution?

Enable a place to set the favicon. This might work nicely in Global Styles as a start as I imagine that would be a natural place where users might look.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Feature] Full Site Editing labels Mar 5, 2021
@carolinan
Copy link
Contributor

I am closing this as it is a duplicate of #29126

@jasmussen jasmussen mentioned this issue Mar 5, 2021
Closed
@annezazu
Copy link
Contributor Author

annezazu commented Mar 6, 2021

Ah! Icon :D Should have searched for that as well as favicon. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carolinan @annezazu