Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation editor - data is lost when menu is deselected #30424

Closed
grzim opened this issue Mar 31, 2021 · 5 comments
Closed

Navigation editor - data is lost when menu is deselected #30424

grzim opened this issue Mar 31, 2021 · 5 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@grzim
Copy link
Contributor

grzim commented Mar 31, 2021

Description

When any change is made in the sidebar and they are unsaved, the user loses them all when clicks on the background (deselect block).

Step-by-step reproduction instructions

  1. Go to Navigation Editor
  2. Select menu (add at least one if you don't have any)
  3. Make a change in a sidebar (change a name or theme locations)
  4. Click on the background
  5. Select the block
  6. See the changes are lost

Expected behaviour

Data should either persist or a user should be warned they will lose it

Actual behaviour

Data is lost when the block is deselected

WordPress information

Gutenberg version: 10.3.0-rc.1

Device information

@grzim grzim added [Type] Bug An existing feature does not function as intended [Package] Edit Navigation labels Mar 31, 2021
@grzim grzim self-assigned this Mar 31, 2021
@talldan
Copy link
Contributor

talldan commented Apr 1, 2021

👍 Seems to only be an issue with the Menu Locations, I couldn't reproduce this issue with the Menu Name.

@getdave
Copy link
Contributor

getdave commented Apr 21, 2021

@talldan Should this be in the PRs pending review column?

@talldan
Copy link
Contributor

talldan commented Apr 21, 2021

I've moved it to the right place and linked the relevant PR 😄

@getdave
Copy link
Contributor

getdave commented Jun 29, 2021

Moving to Needs Dev as it actually needs a developer to take this on.

@Mamaduka
Copy link
Member

I'm closing this issue since the navigation screen is no longer actively developed.

Related: #43620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
4 participants