Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Query block: Adding additional options to the placeholder screen. #30942

Closed
paaljoachim opened this issue Apr 17, 2021 · 4 comments
Closed
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 17, 2021

What problem does this address?

Customizing the Query block can be fairly tricky.
It is also difficult to know which blocks would be natural to add to the Query block.

What is your proposed solution?

Adding additional options to the placeholder screen. Making it even easier to begin with the Query block.

Query-block-placeholder-screen

What are we seeing:
Top row I have added Style Filter icons. Hover over an icon and see its tooltip name. Click to activate the icons and notice the previews will reflect which icons are clicked.

Previews are the same size but show different types of styles. (Image size should be adjustable inside the Query block Featured Image block.) Keeping the previews the same size makes it easier to visually see the different styles. Having different size styles becomes visually distracting, and takes the attention away from the styles.

Below is an empty visual square for Starting empty.

One of the things I noticed when working with the Query block was knowing which blocks were associated with it.
I added the Include blocks area (not sure about this one). So the user can decide in the placeholder screen which blocks to be included. They would not need to hunt and then guess which blocks to include later on.

Btw I turned off the "Inherit query from URL" toggle. As it is best that it begins off so that the various options are not hidden. A user can later on if needed toggle it back on.

I am hoping the above can inspire. The FSE test here: https://make.wordpress.org/test/2021/04/14/fse-program-testing-call-5-query-quest/ got me to really go ahead and test the Query block to see where it is at right now.

Associated merged PR:
#30763

@paaljoachim paaljoachim added [Block] Query Loop Affects the Query Loop Block [Feature] Full Site Editing [Type] Enhancement A suggestion for improvement. labels Apr 17, 2021
@ntsekouras
Copy link
Contributor

Hey Paal 👋 !

I think the direction for Query block is here: #29602. Since is a quite complex block, initialization through patterns might be helpful and will be tried. Please share your thoughts there as it's very related to your issue here.

Also check this issue for future improvements: #30910 and this one: #30369 for inherit and the context detection.

@paaljoachim
Copy link
Contributor Author

Hey Nik!

I copied the full comment over to the PR you mentioned.
Should I close this issue?

@ntsekouras
Copy link
Contributor

Should I close this issue?

I think we can keep it open for now for some discussion, probably after the landing/testing of the Query with patterns in carousel.

@mtias
Copy link
Member

mtias commented Apr 30, 2021

Going to close this so we can focus on the carousel / modal presentation.

@mtias mtias closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants