Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please re-add menu entry for converting a reusble block to a regular one #30993

Closed
scrobbleme opened this issue Apr 20, 2021 · 5 comments
Closed
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Dev Ready for, and needs developer efforts [Type] Regression Related to a regression in the latest release

Comments

@scrobbleme
Copy link

After the latest update users started to complain, that they can't convert reusable blocks to regular blocks anymore...

At first we thought this was a bug...
The new icon is neither descriptive nor intuitive to use... we needed to search for this functionality. No one just clicked the icon...

→ why not just leave an explicit "written" menu entry (at the dot menu)?

If there is an icon button for converting to regular, why is there no one for converting to reusable?

@skorasaurus skorasaurus added [Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Regression Related to a regression in the latest release labels Apr 21, 2021
@skorasaurus
Copy link
Member

skorasaurus commented Apr 21, 2021

Thanks for reporting. Even as a pretty experienced Gutenberg user, I ran into this as well.

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 27, 2021

Good idea! As I have been going over Reusable blocks again I do believe it would be helpful to add it like so:
(Added a light blue background color to emphasize the location. Edited: Added another image...:-)

Adding-text-link-Convert-to-regular-blocks

@paaljoachim paaljoachim added the Needs Dev Ready for, and needs developer efforts label Apr 27, 2021
@scrobbleme
Copy link
Author

scrobbleme commented Apr 27, 2021

@paaljoachim You should highlight the "Convert to regular blocks". Your image looks like, you want to tell something with "Copy" ;)

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 27, 2021

Let's look at a few things.

1-
The icon to "convert to regular blocks"

Reusable-block-toolbar

should be switched out with another icon.

--

2-
Having the "Convert to regular blocks" in the 3 dot (Options) drop down should also help.


@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 1, 2021

A PR to add a text link to the ellipsis (3 dot) drop down has been added through this PR:
#32310 It was just merged, so we can go ahead and close this issue.

Switching the current toolbar icon to a more suitable icon is something we will need to get back to at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Dev Ready for, and needs developer efforts [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants