-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Experimental APIs WP 5.8 #31416
Comments
@youknowriad I'm not sure if this list is up to date? For example I think I see what's happening, the script might be picking up changelog notes. Maybe exclude |
@nerrad good catch, I updated the list by excluding markdown files, how does it look now? |
I can't speak to everything but |
I did a quick first pass.. I believe these should remain
These feel like they could become stable: |
If these are the ones in the block-editor package, I think they should remain experimental because the patterns directory could have an impact there. |
|
I think I saw some discussion about grouping some of these under "typography" ? it would make sense to be but I agree that we can probably stabilize these now, they are a good complement to theme.json for block authors. UI is not a blocker to stabilize things though for me, it can be iterated on. |
That might be what you're thinking of, from #27331. Part of it is to group tools logically, part of it is to avoid a proliferation of panels. |
@nosolosw I think useEditorFeature is something we should stabilize, though I don't like the naming of the hook, maybe more |
Oh, this would be very different to what was implemented at first. Does it mean that it no longer checks the settings in block
This one is hardcoded to always return
It makes me wonder, how block authors can opt in for the feautes like gutenberg/lib/experimental-default-theme.json Line 178 in 0343eda
Will they need to define the hook that updates all settings? I see an override for the Button block in gutenberg/lib/experimental-default-theme.json Lines 221 to 227 in 0343eda
What is the story for custom block creators? |
It's the other way around:
So ultimately, the final decision belongs to the theme author. My post also explains this a bit https://riad.blog/2021/05/05/introduction-to-wordpresss-global-styles-and-global-settings/ |
From the post:
Thank you for sharing this post. It clarified all misconceptions I had based on the initial development efforts I was involved in. |
This is used not only in richtext but also in the Navigation editor and block. It is slightly unorthodox because it lives in Core Data but is not using the |
Right, the idea was to move into the place where it can be shared between all those places. The plan is to find it a better home in the future. @gwwar might have better insights on how to move forward with making it stable. |
Not sure if this is what you mean but it is already in
Currently, the gutenberg/packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js Lines 89 to 97 in 53ef636
I'm not sure what criteria are required to consider this API stable? Do we need to migrate the format to utilise the generator based data fetching mechanics of
Definitely, a good idea to have Kerry's input 👍 Also @talldan if he has a moment. |
For This function is a default implementation specific to WP, and passed through to editor settings on init (post/site/widget/navigation). Folks can currently override this in their custom editor instance, by passing through a different function. Is it worth making these specific default implementations public? (This one is specific to WP). If the answer is yes, I'd prefer not removing the If we don't think there's value to exposing the default implementations, we could perhaps change the prefix to Note that we can probably stabilize the left side of this for editor settings: gutenberg/packages/edit-site/src/index.js Lines 26 to 27 in 73af997
|
I'm going to close this now as we're passed feature freeze. I think I expected a bit more updates here. Anyway, let's continue doing non stop (and not wait for the last moment in the release cycle). Thanks folks. |
This is the list of experimental APIs we have generated by the @noisysocks's script from #28157
The list is long and we doesn't have to go through the entire list but I suggest that If you introduced/used one of these APIs, to follow the following steps: cc @WordPress/gutenberg-core
__unstable
insteadOur goal after a couple weeks should be to change the status of a dozen of APIs (whether it's marking them unstable or stable).
packages/annotations
__experimentalAddAnnotation
__experimentalCreateOnChangeEditableValue
__experimentalCreatePrepareEditableTree
__experimentalGetAllAnnotationsForBlock
__experimentalGetAnnotations
__experimentalGetAnnotationsForBlock
__experimentalGetAnnotationsForRichText
__experimentalGetPropsForEditableTreeChangeHandler
__experimentalGetPropsForEditableTreePreparation
__experimentalRemoveAnnotation
__experimentalRemoveAnnotationsBySource
__experimentalUpdateAnnotationRange
packages/block-directory
__experimentalInserterMenuExtension
#31417packages/block-editor
__experimentalAlignmentMatrixControl
__experimentalAppenderTagName
__experimentalBlock
#31419__experimentalBlockAlignmentMatrixControl
__experimentalBlockDirectory
__experimentalBlockFullHeightAligmentControl
__experimentalBlockNavigationBlockFill
__experimentalBlockNavigationEditor
__experimentalBlockNavigationTree
__experimentalBlockPatternCategories
__experimentalBlockPatternSetup
__experimentalBlockPatterns
__experimentalBlockSettingsMenuFirstItem
#31420__experimentalBlockVariationPicker
__experimentalBlockVariationTransforms
__experimentalBorder
__experimentalBorderStyleControl
__experimentalBoxControl
__experimentalCanUserUseUnfilteredHTML
__experimentalCaptureToolbars
__experimentalCloneSanitizedBlock
__experimentalColorGradientControl
__experimentalConvertBlockToStatic
__experimentalDragComponent
__experimentalDuotone
__experimentalDuotoneControl
__experimentalFeatures
__experimentalFetchLinkSuggestions
__experimentalFontAppearanceControl
__experimentalFontFamily
__experimentalFontFamilyControl
__experimentalFontStyle
__experimentalFontWeight
__experimentalGetAccessibleBlockLabel
__experimentalGetActiveBlockIdByBlockNames
__experimentalGetAllowedBlocks
__experimentalGetAllowedPatterns
__experimentalGetBlockLabel
__experimentalGetBlockListSettingsForBlocks
__experimentalGetBorderClassesAndStyles
__experimentalGetColorClassesAndStyles
__experimentalGetGradientClass
__experimentalGetGradientObjectByGradientValue
__experimentalGetLastBlockAttributeChanges
__experimentalGetMatchingVariation
__experimentalGetParsedPattern
__experimentalGetParsedReusableBlock
__experimentalGetPatternTransformItems
__experimentalGetPatternsByBlockTypes
__experimentalGetReusableBlockTitle
__experimentalGradientPicker
__experimentalGradientPickerControl
__experimentalGradientPickerPanel
__experimentalHandleURLSuggestions
__experimentalImageSizeControl
__experimentalImageURLInputUI
__experimentalInitialIndex
__experimentalInserterMenuExtension
__experimentalInsertionIndex
__experimentalIsQuick
__experimentalLayout
__experimentalLayoutStyle
__experimentalLibrary
__experimentalLinkControl
__experimentalLinkControlSearchInput
__experimentalLinkControlSearchItem
__experimentalLinkControlSearchResults
__experimentalLive
__experimentalNoWrapper
__experimentalOnClick
__experimentalOnIndexChange
__experimentalOnlyMediaLibrary
__experimentalPadding
__experimentalPanelColorGradientSettings
__experimentalParentSelector
__experimentalPersistentListViewFeatures
__experimentalPreferredStyleVariations
__experimentalPreviewOptions
__experimentalRenderControl
__experimentalRenderSuggestions
__experimentalResponsiveBlockControl
__experimentalReusableBlocks
__experimentalRichText
__experimentalRole
__experimentalSearchForm
__experimentalSelectBlock
__experimentalSelector
__experimentalSetIsInserterOpened
__experimentalShouldInsertAtTheTop
__experimentalShowInitialSuggestions
__experimentalSkipFontSizeSerialization
__experimentalSkipSerialization
__experimentalSpotlightEntityBlocks
__experimentalStyleProvider
__experimentalTextDecoration
__experimentalTextTransform
__experimentalToolbar
__experimentalToolbarContext
__experimentalTransferDataType
__experimentalTreeGrid
__experimentalTreeGridCell
__experimentalTreeGridItem
__experimentalTreeGridRow
__experimentalUndo
__experimentalUnitControl
__experimentalUpdateSelection
__experimentalUseBorderProps
__experimentalUseColorProps
__experimentalUseColors
__experimentalUseCustomSides
__experimentalUseDropZone
__experimentalUseEditorFeature
__experimentalUseGradient
__experimentalUseInnerBlocksProps
__experimentalUseNoRecursiveRenders
__experimentalUseResizeCanvas
__experimentalUseSimulatedMediaQuery
__experimentalUseSlot
__experimentalVersion
packages/block-library
__experimentalAppenderTagName
__experimentalBlockAlignmentMatrixControl
__experimentalBlockFullHeightAligmentControl
__experimentalBlockNavigationTree
__experimentalBlockVariationPicker
__experimentalBorder
__experimentalBoxControl
__experimentalCaptureToolbars
__experimentalConvert
__experimentalConvertBlockToStatic
__experimentalDuotone
__experimentalFeatures
__experimentalFontFamily
__experimentalFontStyle
__experimentalFontWeight
__experimentalGetBorderClassesAndStyles
__experimentalGetColorClassesAndStyles
__experimentalGetCoreBlocks
__experimentalGetDefaultTemplatePartAreas
__experimentalGetGradientClass
__experimentalGetSettings
__experimentalImageSizeControl
__experimentalImageURLInputUI
__experimentalIsEditingReusableBlock
__experimentalLabel
__experimentalLayout
__experimentalLinkControl
__experimentalLive
__experimentalNumberControl
__experimentalOnClick
__experimentalPanelColorGradientSettings
__experimentalRegisterExperimentalCoreBlocks
__experimentalRole
__experimentalSearchForm
__experimentalSelector
__experimentalShowTooltip
__experimentalSkipSerialization
__experimentalTextDecoration
__experimentalTextTransform
__experimentalTooltipProps
__experimentalUnitControl
__experimentalUseBorderProps
__experimentalUseColorProps
__experimentalUseEditorFeature
__experimentalUseGradient
__experimentalUseInnerBlocksProps
__experimentalUseNoRecursiveRenders
__experimentalVersion
packages/blocks
__experimentalBorder
__experimentalCloneSanitizedBlock
__experimentalConvert
__experimentalFontFamily
__experimentalFontStyle
__experimentalFontWeight
__experimentalGetAccessibleBlockLabel
__experimentalGetBlockAttributesNamesByRole
__experimentalGetBlockLabel
__experimentalLabel
__experimentalRole
__experimentalSanitizeBlockAttributes
__experimentalTextDecoration
__experimentalTextTransform
packages/components
__experimentalAlignmentMatrixControl
__experimentalBoxControl
__experimentalColorEdit
__experimentalCustomGradientPicker
__experimentalDimensionControl
__experimentalDragComponent
__experimentalExpandOnFocus
__experimentalFetchLinkSuggestions
__experimentalFlex
__experimentalFlexBlock
__experimentalFlexItem
__experimentalGetSettings
__experimentalGradientPicker
__experimentalHeading
__experimentalInputControl
__experimentalInvalid
__experimentalIsFocusable
__experimentalNavigation
__experimentalNavigationBackButton
__experimentalNavigationGroup
__experimentalNavigationItem
__experimentalNavigationMenu
__experimentalNumberControl
__experimentalRadio
__experimentalRadioGroup
__experimentalShowHowTo
__experimentalShowTooltip
__experimentalStyleProvider
__experimentalText
__experimentalToolbarContext
__experimentalTooltipProps
__experimentalTransferDataType
__experimentalTreeGrid
__experimentalTreeGridCell
__experimentalTreeGridItem
__experimentalTreeGridRow
__experimentalTruncate
__experimentalUnitControl
__experimentalUseDragging
__experimentalUseDropZone
__experimentalUseFocusOutside
__experimentalUseSlot
__experimentalValidateInput
packages/compose
__experimentalUseDialog
__experimentalUseDragging
__experimentalUseDropZone
__experimentalUseFocusOutside
__experimentalWidthProvider
packages/core-data
__experimentalBatch
__experimentalFetchLinkSuggestions
__experimentalGetDirtyEntityRecords
__experimentalGetEntityRecordNoResolver
__experimentalGetTemplateForLink
__experimentalSaveSpecifiedEntityEdits
packages/customize-widgets
__experimentalBlockSettingsMenuFirstItem
__experimentalGetCoreBlocks
__experimentalLibrary
__experimentalRegisterExperimentalCoreBlocks
__experimentalSetIsInserterOpened
packages/data
__experimentalListeningStores
__experimentalMarkListeningStores
__experimentalSubscribeStore
__experimentalUseThunks
packages/date
__experimentalGetSettings
packages/e2e-tests
__experimentalAddAnnotation
__experimentalConvert
__experimentalRemoveAnnotationsBySource
__experimentalUpdateLocalAutosaveInterval
packages/edit-navigation
__experimentalFetchLinkSuggestions
__experimentalIsFocusable
__experimentalRegisterExperimentalCoreBlocks
packages/edit-post
__experimentalBlockSettingsMenuFirstItem
__experimentalFullscreenModeClose
__experimentalGetInsertionPoint
__experimentalGetPreviewDeviceType
__experimentalGetTemplateForLink
__experimentalInsertionIndex
__experimentalLayout
__experimentalLayoutStyle
__experimentalLibrary
__experimentalLocalAutosaveInterval
__experimentalMainDashboardButton
__experimentalNavigation
__experimentalNavigationItem
__experimentalNavigationMenu
__experimentalPreferredStyleVariations
__experimentalPreviewOptions
__experimentalRegisterExperimentalCoreBlocks
__experimentalSetIsInserterOpened
__experimentalSetPreviewDeviceType
__experimentalUpdateLocalAutosaveInterval
__experimentalUseDialog
__experimentalUseEditorFeature
__experimentalUseResizeCanvas
__experimentalUseSlot
packages/edit-site
__experimentalBlockNavigationTree
__experimentalBlockSettingsMenuFirstItem
__experimentalBorderStyleControl
__experimentalBoxControl
__experimentalColorEdit
__experimentalColorGradientControl
__experimentalFeatures
__experimentalFetchLinkSuggestions
__experimentalFontAppearanceControl
__experimentalFontFamilyControl
__experimentalGetActiveBlockIdByBlockNames
__experimentalGetBlockLabel
__experimentalGetDefaultTemplatePartAreas
__experimentalGetDefaultTemplateTypes
__experimentalGetDirtyEntityRecords
__experimentalGetInsertionPoint
__experimentalGetPreviewDeviceType
__experimentalGetTemplateForLink
__experimentalGetTemplateInfo
__experimentalGlobalStylesBaseStyles
__experimentalGlobalStylesUserEntityId
__experimentalInsertionIndex
__experimentalLayout
__experimentalLibrary
__experimentalLinkControl
__experimentalMainDashboardButton
__experimentalNavigation
__experimentalNavigationBackButton
__experimentalNavigationGroup
__experimentalNavigationItem
__experimentalNavigationMenu
__experimentalNavigationToggle
__experimentalNoWrapper
__experimentalPanelColorGradientSettings
__experimentalPersistentListViewFeatures
__experimentalPreviewOptions
__experimentalRadio
__experimentalRadioGroup
__experimentalRegisterExperimentalCoreBlocks
__experimentalSelector
__experimentalSetIsInserterOpened
__experimentalSetPreviewDeviceType
__experimentalSpotlightEntityBlocks
__experimentalText
__experimentalUseCustomSides
__experimentalUseDialog
__experimentalUseResizeCanvas
__experimentalUseSlot
packages/edit-widgets
__experimentalBatch
__experimentalFetchLinkSuggestions
__experimentalGetCoreBlocks
__experimentalGetDirtyEntityRecords
__experimentalInsertionIndex
__experimentalLabel
__experimentalLibrary
__experimentalParentSelector
__experimentalRegisterExperimentalCoreBlocks
__experimentalReusableBlocks
__experimentalSetIsInserterOpened
__experimentalToolbar
__experimentalUseDialog
packages/editor
__experimentalBlockDirectory
__experimentalBlockPatternCategories
__experimentalBlockPatterns
__experimentalCanUserUseUnfilteredHTML
__experimentalFeatures
__experimentalFetchLinkSuggestions
__experimentalGetDefaultTemplatePartAreas
__experimentalGetDefaultTemplateType
__experimentalGetDefaultTemplateTypes
__experimentalGetDirtyEntityRecords
__experimentalGetSettings
__experimentalGetTemplateInfo
__experimentalGlobalStylesBaseStyles
__experimentalGlobalStylesUserEntityId
__experimentalLocalAutosaveInterval
__experimentalPreferredStyleVariations
__experimentalRequestPostUpdateFinish
__experimentalRequestPostUpdateStart
__experimentalReusableBlocks
__experimentalRichText
__experimentalSaveSpecifiedEntityEdits
__experimentalSetIsInserterOpened
__experimentalShouldInsertAtTheTop
__experimentalTearDownEditor
__experimentalUndo
__experimentalUseDialog
packages/eslint-plugin
__experimentalFoo
__experimentalSafe
__experimentalUnsafe
packages/format-library
__experimentalLinkControl
__experimentalUseEditorFeature
packages/reusable-blocks
__experimentalConvertBlockToStatic
__experimentalConvertBlocksToReusable
__experimentalDeleteReusableBlock
__experimentalIsEditingReusableBlock
__experimentalSetEditingReusableBlock
packages/rich-text
__experimentalCreateOnChangeEditableValue
__experimentalCreatePrepareEditableTree
__experimentalGetPropsForEditableTreeChangeHandler
__experimentalGetPropsForEditableTreePreparation
__experimentalRichText
packages/server-side-render
__experimentalSanitizeBlockAttributes
lib
__experimentalBlockPatternCategories
__experimentalBlockPatterns
__experimentalBorder
__experimentalDuotone
__experimentalFeatures
__experimentalFontFamily
__experimentalFontStyle
__experimentalFontWeight
__experimentalGlobalStylesBaseStyles
__experimentalGlobalStylesUserEntityId
__experimentalLayout
__experimentalNoWrapper
__experimentalSelector
__experimentalSkipFontSizeSerialization
__experimentalSkipSerialization
__experimentalTextDecoration
__experimentalTextTransform
The text was updated successfully, but these errors were encountered: