"onDismiss" option in "createInfoNotice" is not taken into account

[kmgalanakis]

When using wp.data.dispatch( 'core/notices' ).createInfoNotice and trying to pass a function for the onDismiss option, the function is not triggered when the notice is dismissed.

Typing something like wp.data.dispatch( 'core/notices' ).createInfoNotice( 'hello', { onDismiss: () => { console.log( 'dismissed!' ) } } ); is not logging anything in the console, when the created notice is dismissed.

Further information can be found here.

[talldan]

Seems like this was implemented for Snackbar notices in #26952, but the implementation wasn't extended to normal notices.

Hopefully it should be a simple matter of implementing the onDismiss in the Notice component, and the implementation in Snackbar can serve as a good guide.

[vdwijngaert]

Hey @talldan,

I checked it out yesterday when the question arose on slack, should be an easy fix. Something like replacing

gutenberg/packages/components/src/notice/list.js

Line 23 in b773369

const removeNotice = ( id ) => () => onRemove( id );

with

const removeNotice = ( notice ) => () => {
   if( notice.onDismiss ) {
      notice.onDismiss( notice.id );
   }
   onRemove(notice.id);
};

This is where Snackbar did it:

gutenberg/packages/components/src/snackbar/index.js

Line 66 in c0cb714

onDismiss();