Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a back button in BlockVariationPicker if used with BlockPatternSetup #31593

Open
ntsekouras opened this issue May 7, 2021 · 2 comments
Open
Labels
[Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.

Comments

@ntsekouras
Copy link
Contributor

What problem does this address?

If we use in a block the __experimentalBlockPatternSetup and matching patterns are available, the user will be prompted to choose among the patterns. If the specific block has also block variations to be shown and uses __experimentalBlockPatternSetup when the user chooses to start blank, they need a way (a back button) to go to the patterns picker view.

The problem exists for Query block but could apply for other blocks with the same conditions, and was presented by @annezazu with the following video:

query.undo.with.patterns.mov
@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. [Package] Block editor /packages/block-editor labels May 7, 2021
@ntsekouras ntsekouras changed the title Add conditionally a back button in __experimentalBlockVariationPicker if used with __experimentalBlockPatternSetup Add conditionally a back button in BlockVariationPicker if used with BlockPatternSetup May 7, 2021
@ntsekouras ntsekouras changed the title Add conditionally a back button in BlockVariationPicker if used with BlockPatternSetup Add a back button in BlockVariationPicker if used with BlockPatternSetup May 7, 2021
@annezazu
Copy link
Contributor

@ntsekouras would this by chance apply to the navigation block at all? Asking because I noticed I can't undo under specific circumstances namely if the existing menu I add is empty:

undo.mov

@ntsekouras
Copy link
Contributor Author

@ntsekouras would this by chance apply to the navigation block at all?

Navigation block is using different components with different implementation, so this is a different issue.

--cc @draganescu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants