-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Editing mode hindered by plugin's meta boxes #31789
Comments
I can't reproduce this with the core meta box for custom fields. It might be a problem with Yoast SEO? |
I tested with Yoast SEO deactivated and by activating a theme that has meta boxes (Aaron). With Gutenberg trunk or 10.6.0 active, I am seeing the black background color around the meta box both in the post editor and template editing editing mode. |
I was still on version 10.5.4 when I couldn't reproduce it before. After updating to version 10.6, I'm now able to reproduce it with the core meta box for custom fields. Therefore, it's definitely a new regression introduced by version 10.6. Can I also just say that the new black padding is extremely ugly, and shrinking the physical size of the canvas seems like a very strange way to communicate the increased editing scope in template mode. I think there needs to be a rethink of how to remind the user they are in template mode. Perhaps an informational strap at the top, similar to the ones for autosaves and updating failed, rather than extra padding? |
Let's try to remove the meta boxes from the template mode. |
I'd rather they not be removed altogether, as they can still be useful in template mode. This was not a problem in version 10.5, where they were just collapsed as normal. |
I think it doesn't make sense to keep them as most of them contain "post related things" and the "sidebar ones" are removed, so it makes sense to be consistent and remove the "content ones" as well. |
I agree to err on the side of consistency, although I'm not convinced the sidebar ones should be removed either, because the new sidebar that replaces them is practically empty. If there were some template-related tools to take their place, I think there'd be a stronger case for removing them. It will also be interesting to see whether any/many users report that they prefer the template mode to the standard mode for editing the post itself. |
Description
When a plugin such as Yoast SEO is activated and you enter Template Editing mode the
meta boxes that normally appear below the content get pride of place and scroll into view.
Step-by-step reproduction instructions
Expected behaviour
I think the meta boxes should be hidden when editing the template.
Actual behaviour
The meta boxes are a bit in your face.
They can be minimised, but it has to be done each time.
Screenshots or screen recording (optional)
Code snippet (optional)
WordPress information
thisis
.Device information
The text was updated successfully, but these errors were encountered: