Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Screen: Dirty state is not reset after saving #32074

Closed
Mamaduka opened this issue May 21, 2021 · 3 comments · Fixed by #32573
Closed

Widget Screen: Dirty state is not reset after saving #32074

Mamaduka opened this issue May 21, 2021 · 3 comments · Fixed by #32573
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@Mamaduka
Copy link
Member

Description

When adding a new block, sometimes you have to save changes twice to clear unsaved changes.

Step-by-step reproduction instructions

  1. Go to the new widgets screen.
  2. Add a new block to a widget area.
  3. Save changes.
  4. See snackbar appear.
  5. "Update" button isn't disabled.

Expected behaviour

The "Update" button should be disabled after saving changes the first time.

Actual behaviour

Have to save changes twice to see a visual indication that they are saved.

Screenshots or screen recording (optional)

widget-screen-save-twice.mp4

WordPress information

  • WordPress version: 5.7.2
  • Gutenberg version: 10.7/trunk
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels May 21, 2021
@noisysocks
Copy link
Member

Confirmed.

@noisysocks noisysocks changed the title Widget Screen: Requires saving changes twice Widget Screen: Dirty state is not reset after saving Jun 1, 2021
@Mamaduka
Copy link
Member Author

Mamaduka commented Jun 1, 2021

I will try to look into this issue later this week.

@noisysocks
Copy link
Member

Related to this is that you see a "Are you sure?" prompt when you navigate away from the widgets screen after saving.

@noisysocks noisysocks self-assigned this Jun 10, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants