-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display wide widgets as modals in Customizer #32210
Comments
Thanks for the exploration @critterverse ! This is something we may be able to look at in the future, but is too complex to try implementing for this release, given that we're past feature freeze and getting close to Beta 1. The main technical problem here is how to move the block toolbar into a modal. The block toolbar component sits outside the content area of the editor, and we can't control where it renders from inside the block, so we'd need to modify the actual toolbar component to support that behaviour. |
This solution is creative. Technical challenges aside, I don't see using the modal as advancing the interface as compared to what the Customizer (before/without the block editor) provides for wide widgets. I do believe it's generally agreed that what we have now should be improved upon. So to that end I've explored a couple of ways to bring the wide widget display closer to the pre-block-editor interface, #33230 and #33236. The former is an approach to improve the popover positioning. The latter is also that (implemented differently) plus a few more changes as proposed improvements. I don't know how much a priority any of this would be so I'm not urging anyone to try them out but merely marking their existence. |
I agree with @stokesman that improving what we already have is likely more practical (from a cost benefit point of view) than a new modal interface. |
Hi all, this is an alternate solution to the issue being explored in #31736. We originally tried to use the popover component to display wide widgets in the Customizer, but it's proving to be difficult to wrangle in terms of positioning, size, etc.
A modal solution might provide a more consistent user experience:
Using the move arrows could be similar to reordering nav items from the “block navigation” action in the Navigation block toolbar, where the items move around behind the overlay:
navigation-block.mov
I think any actions from the ellipses menu would close the modal and take place in the sidebar while the legacy widget is in preview mode.
Thoughts on this direction?
The text was updated successfully, but these errors were encountered: