Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets editor: Block toolbar doesn't appear after selecting multiple blocks #32419

Closed
noisysocks opened this issue Jun 3, 2021 · 4 comments · Fixed by #32536
Closed

Widgets editor: Block toolbar doesn't appear after selecting multiple blocks #32419

noisysocks opened this issue Jun 3, 2021 · 4 comments · Fixed by #32536
Assignees
@talldan
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

noisysocks commented Jun 3, 2021 •
edited
Loading

Description

The block toolbar does not appear after selecting multiple blocks in the widgets editor.

Step-by-step reproduction instructions

  1. Go to Appearance → Widgets.
  2. Select multiple blocks e.g. by shift + clicking.

Expected behaviour

The block toolbar should appear.

Screen Shot 2021-06-03 at 13 36 40

Actual behaviour

Behaviour is inconsistent. Sometimes no toolbar appears. Sometimes a toolbar for the last block appears.

Screen Shot 2021-06-03 at 13 38 35
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Jun 3, 2021
@tellthemachines tellthemachines self-assigned this Jun 7, 2021
@tellthemachines
Copy link
Contributor

tellthemachines commented Jun 7, 2021 •
edited
Loading

I definitely noticed this issue before, but am unable to reproduce it now, either in WP trunk or Gutenberg. Could you re-check? I'm using latest Chrome fwiw.

Edit: I can't repro this on Safari or Firefox either.

@draganescu
Copy link
Contributor

Same as @tellthemachines I cannot repro in WP trunk with Gtb trunk.

@noisysocks
Copy link
Member Author

Yes I can still repro in both WordPress trunk and Wordpress trunk + Gutenberg trunk using both Firefox and Chrome. I have Twenty Twenty-one activated.

Kapture.2021-06-08.at.11.08.07.mp4

@tellthemachines tellthemachines removed their assignment Jun 9, 2021
@talldan
Copy link
Contributor

talldan commented Jun 9, 2021

I think this is the same bug as #32056 - shift clicking to multi-select doesn't seem to work in nested blocks (e.g. widget areas).

@talldan talldan self-assigned this Jun 9, 2021
@talldan talldan mentioned this issue Jun 9, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix block multi selection in nested blocks WordPress/gutenberg
4 participants
@draganescu @noisysocks @talldan @tellthemachines