Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preferences modal to the Widgets screen #32711

Open
critterverse opened this issue Jun 15, 2021 · 1 comment
Open

Add Preferences modal to the Widgets screen #32711

critterverse opened this issue Jun 15, 2021 · 1 comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@critterverse
Copy link
Contributor

critterverse commented Jun 15, 2021

Opening this issue based on feedback in #32569 (comment).

When we first introduced the ellipses menu into the Widget editors, only one Preference was available (compared to 10+ available in the post editor), so it was introduced as an inline option within the ellipses menu. Now that we are starting to adding more Preferences, we should look at introducing the Preferences modal.

One consideration is that there are only two Preferences available currently, which would reduce the submenu down to two pages with one item on each. But I think the UI holds up and will likely get more filled in over time:

Preferences modal showing the "General" tab with one option
Preferences modal showing the "Blocks" tab with one option

Since there's currently only one Preference available to the Customize Widgets screen, I would lean towards leaving that as an inline option in the ellipses menu until at least one more option is added.

@critterverse critterverse added [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts labels Jun 15, 2021
@talldan
Copy link
Contributor

talldan commented Jun 17, 2021

Relevant to this is #31965. We could do with a bit of a refactor of editor preferences, as they're all implemented as part of the post editor.

I have started work on this, but I'm not prioritising it until 5.8 is shipped.

@noisysocks noisysocks changed the title Introduce Preferences modal on the Widget screen Add Preferences modal to the Widgets screen Jul 7, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants