Mobile: Keep Settings Sheet Open After Setting a Featured Image via the Image Block

[SiobhyB]

Description

When a user navigates to the image block's settings and taps the button to "Set/Remove as Featured", the settings sheet is dismissed. This could be viewed as a bit jarring and, as we've iterated on the design of the "Set/Remove as Featured" button, it'd be preferable to keep the user in the settings sheet when they tap it.

As discussed here, this won't be as simple as removing the call to closeSettingsBottomSheet from here in the code due to the fact we display a confirmation dialog when users already have a featured image set.

The bug described at #29672 means that, by default, the app will crash on iOS if we attempt to display the settings and the confirmation dialog at the same time. We could look into the workaround mentioned in the comments of that GitHub issue or consider removing the confirmation dialog altogether.

(As a side note, this would likely tie in nicely with a suggested enhancement for improving the confirmation dialog at #30410.)

Step-by-step reproduction instructions

• In the app, navigate to Home → Blog Posts.
• Add a new image block and upload an image to it.
• Tap the image block's cog/gear icon to access its settings and then tap the Set/Remove as Featured button at the bottom.

Expected behaviour

To remain within the block's settings panel, where I can continue to adjust settings as needed and read the footer message, which is specific to the featured image changes. As mentioned here by @iamthomasbishop, this behaviour would make the most sense.

Actual behaviour

Tapping on the Set/Remove as Featured button takes you out of the settings panel.

Screenshots or screen recording (optional)

Screen.Recording.2021-08-02.at.15.13.27.mov