Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content is locked by another user overlay is not shown correcly #3446

Closed
2 tasks
grappler opened this issue Nov 12, 2017 · 5 comments
Closed
2 tasks

The content is locked by another user overlay is not shown correcly #3446

grappler opened this issue Nov 12, 2017 · 5 comments

Comments

@grappler
Copy link
Member

Issue Overview

When the content is locked by another user the overlay is not shown correctly when a plugin with a meta box like Yoast SEO is installed. When the plugin is not installed there is no overlay so there is no way of knowing that someone is editing the post.

Steps to Reproduce (for bugs)

  1. Open a post with one user account
  2. Enable Yoast SEO
  3. Open the same post with another user account
  4. See the overlay in the Yoast SEO Meta Box

Expected Behavior

The overlay is shown across the whole editor and not just in the Yoast SEO Meta Box

Screenshots / Video

image

Todos

  • Tests
  • Documentation
@StaggerLeee
Copy link

StaggerLeee commented Nov 13, 2017

This is also one of the very strange things from "old" WordPress core.

How it is possible Editor can take over Post from Admin and kick Admin out of the Post ?
How it is possible the same Role can kick each other out of the Post ?

Maybe there is a reason I am not aware of.
Heartbeat should "logout" an User from Post after some time of inactivity. If not User is editing and nobody other should meddle in affair.

@pento
Copy link
Member

pento commented Nov 13, 2017

I can reproduce this issue in master, but it's actually fixed as a side effect of #3345, which changes the metabox handler to not use iframes, so I'm going to close this issue in favour of that PR.

Thanks for the bug report, @grappler!

@pento pento closed this as completed Nov 13, 2017
@grappler
Copy link
Member Author

grappler commented Nov 13, 2017

Good to know that it will be fixed. Might have been best to close the issue once the PR is merged.

@pento does it make sense to create a new issue for Gutenberg to support the locked overlay? At the moment there is no way of knowing is someone else is editing the post.

@pento
Copy link
Member

pento commented Nov 13, 2017

Hopefully, post locking will become redundant with the work on collaborative editing (#1930). So, no need for an issue at the moment, but we can revisit that later if it turns out we still need some sort of post locking interface.

@gziolo
Copy link
Member

gziolo commented Nov 13, 2017

@pento collaborative editing is being developed as a plugin, and even if it would be a part of the Gutenberg it's still optional. I think we should open an issue to add the post locking feature based on heartbeat anyway. /cc @mtias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants