Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Author: Add support for font weight #34640

Closed
Tracked by #38533
scruffian opened this issue Sep 8, 2021 · 2 comments
Closed
Tracked by #38533

Post Author: Add support for font weight #34640

scruffian opened this issue Sep 8, 2021 · 2 comments
Labels
[Block] Post Author Affects the Post Author Block [Feature] Blocks Overall functionality of blocks

Comments

@scruffian
Copy link
Contributor

What problem does this address?

It would be good to be able to set a font weight for the Post Author name. The weight should only target the author's name, not the byline.

@scruffian scruffian added [Feature] Blocks Overall functionality of blocks [Block] Post Author Affects the Post Author Block labels Sep 8, 2021
@mtias mtias mentioned this issue Sep 8, 2021
65 tasks
@apeatling apeatling moved this to ⏱ Not Started in Design Tools Project Nov 2, 2021
@ramonjd
Copy link
Member

ramonjd commented Nov 2, 2021

#34064 is in train to add font weight and style appearance to the Post Author block, albeit at the block container level.

Block support applies the styles to block's root element by default.

One way to target inner blocks is to use __experimentalSkipSerialization, and apply the styles to the inner blocks manually in the block itself.

The catch is that global styles/theme.json style definition can't yet target inner blocks in the same way.

There is an ongoing discussion about how to tackle this challenge, as there are now several blocks with similar requirements.

See: #33255

@aaronrobertshaw
Copy link
Contributor

This issue was resolved with the creation of a Post Author Name block that adopted font-weight support. That block was also extended to have full typography supports in #43319

Repository owner moved this from ⏱ Not Started to ✅ Done in Design Tools Project Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Author Affects the Post Author Block [Feature] Blocks Overall functionality of blocks
Projects
Status: Done
Development

No branches or pull requests

3 participants