Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block captions: Add support for margins and alignment #34642

Closed
scruffian opened this issue Sep 8, 2021 · 2 comments
Closed

Video block captions: Add support for margins and alignment #34642

scruffian opened this issue Sep 8, 2021 · 2 comments
Labels
[Block] Video Affects the Video Block [Feature] Blocks Overall functionality of blocks

Comments

@scruffian
Copy link
Contributor

What problem does this address?

Themes need a way to style captions inside video blocks, especially margins and text alignment properties.

What is your proposed solution?

We could do this by adding controls to the video block, so that users can edit them, or we could just make the controls available in theme.json.

Alternatively we could add support for the figcaption element to the elements part of theme.json, and apply the same settings to images and videos.

@scruffian scruffian added [Feature] Blocks Overall functionality of blocks [Block] Video Affects the Video Block labels Sep 8, 2021
@carolinan
Copy link
Contributor

Can this issue be closed? The caption can be styled using theme.json and global styles. (Classic themes can keep using CSS)

@scruffian
Copy link
Contributor Author

Yes, let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Video Affects the Video Block [Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

2 participants