Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Block: Add support for color and border #34645

Closed
scruffian opened this issue Sep 8, 2021 · 4 comments · Fixed by #34727
Closed

HTML Block: Add support for color and border #34645

scruffian opened this issue Sep 8, 2021 · 4 comments · Fixed by #34727
Assignees
Labels
[Block] HTML Affects the the HTML Block [Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@scruffian
Copy link
Contributor

What problem does this address?

Themes need a way to customize the HTML block, particularly the color and border properties.

What is your proposed solution?

We can add support for color and border to block so that it can be changed via theme.json.

@scruffian scruffian added [Feature] Blocks Overall functionality of blocks [Block] HTML Affects the the HTML Block labels Sep 8, 2021
@mtias
Copy link
Member

mtias commented Sep 8, 2021

Not sure I follow this one. The html block just renders the html on the front?

@scruffian
Copy link
Contributor Author

In Quadrat for example we are modifying the color and border of the textarea in the editor, so that it matches the forms in the front end:

Screenshot 2021-09-09 at 09 32 50

Without this the HTML block is pretty hard to use:

Screenshot 2021-09-09 at 09 32 42

Perhaps this will be dealt with when we allow form elements in Global Styles...

@mtias
Copy link
Member

mtias commented Sep 9, 2021

This seems like the HTML block should force a white background. cc @jasmussen It's not meant to blend with the theme, it's a code view that will render the HTML on the front anyways.

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Sep 9, 2021
@jasmussen
Copy link
Contributor

Right, the HTML block should be considered "editor UI", and have the same materials and styling as the block toolbar. I'll see if I can increase the specificity of those styles to survive anything the theme throws at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] HTML Affects the the HTML Block [Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants