Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceOver and Navigation Block (Responsive Menu): Empty Navigation #35122

Closed
TeBenachi opened this issue Sep 24, 2021 · 5 comments
Closed

VoiceOver and Navigation Block (Responsive Menu): Empty Navigation #35122

TeBenachi opened this issue Sep 24, 2021 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@TeBenachi
Copy link
Contributor

TeBenachi commented Sep 24, 2021

Description

This is an issue with Firefox. When the navigation is set as a responsive menu, VoiceOver reads it as "Empty Navigation" and doesn’t read each link. When the navigation is not responsive, VoiceOver works as expected.

Step-by-step reproduction instructions

  1. On the Site Editor, add a Navigation Block and select the Start Empty option.
  2. Use the Custom Link Block to add links.
  3. In the sidebar settings, under the Displaying settings, enable the responsive menu.
  4. Save and view the website.
  5. While the VoiceOver is on, move focus to the navigation menu using the Tab key.

Screenshots, screen recording, code snippet

VoiceOver reads as "empty navigation."

empty-nav

The accessibility tool shows ARIA alerts with aria-hidden="true" on the menu links.

screenshot3

Environment info

  • WordPress 5.8.1 Gutenberg v11.5.1
  • Firefox 92.0.1 on macOS Big Sur

No VoiceOver issue on Chrome and Safari, however the accessibility tool shows ARIA alerts on all browsers, Firefox, Chrome and Safari on MacOS.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@skorasaurus skorasaurus added Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 28, 2021
@talldan talldan added the [Block] Navigation Affects the Navigation Block label Oct 13, 2021
@tellthemachines
Copy link
Contributor

This was likely caused by the aria-hidden on the responsive container, and if so it should have been fixed by #36292. @TeBenachi could you check with Gutenberg 11.9 if you can still reproduce it?

@TeBenachi
Copy link
Contributor Author

Thank you so much for the updates!

I can confirm the screen reader does not announce “empty” any longer, but it now reads “dialog” instead. I'm wondering if it's possible to have the screen reader read “Main navigation” or something similar to indicate these links are navigation menu. Some screen reader users might think the link will open a modal.

I’ve tested using WP 5.8.2 + GB 11.9.1 on FireFox on Mac.

TabScreenReader

@tellthemachines
Copy link
Contributor

Ah, that's another bug. It should be fixed by #36617.

@Mamaduka
Copy link
Member

I think this was fixed via #37434.

@tellthemachines
Copy link
Contributor

I'm going to close this one as fixed, because the Navigation block is no longer a dialog by default. @TeBenachi feel free to reopen or create other issues if you feel the experience isn't quite right yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

5 participants