Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing block placeholders #35501

Closed
3 tasks done
jameskoster opened this issue Oct 11, 2021 · 1 comment
Closed
3 tasks done

Site Editing block placeholders #35501

jameskoster opened this issue Oct 11, 2021 · 1 comment
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Oct 11, 2021

A couple of recent PRs have sought to tidy up placeholder states for some of the site editing blocks:

It would be good to do this holistically across all of the site editing blocks.

To clarify, these placeholders are for situations in which the blocks have no data to reference.

Here's how they look currently:

Screenshot 2021-10-11 at 11 13 34

There are several inconsistencies to address here. We have different content schemas, styling, image handling and so on.

For the text-based blocks, it's probably adequate to let the theme stylesheet handle their appearance. So let's remove any styling like padding, borders, font-size etc.

In regards to their content, I'm inclined to say that echoing the block name is probably the simplest and most intuitive approach for now. So instead of "An example title" and "no date" we'd have "Post title" and "Post date". This feels like a good foundation from which we can potentially do something more elaborate in the future ("Hello Dolly" for placeholder content?).

The new dashed outline applied to the site logo works well, so perhaps we can try that for the Featured Image as well.

@noisysocks
Copy link
Member

Closing this out in favour of #36136 which is more specific/actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants