-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link UI closing behaviour inconsistencies #35795
Comments
I'd expect the behaviour to be consistent whether the URL is actually changed or not; my preference would be for it always closing when submit is clicked, but I'm not sure if it was implemented as it is for a reason, so would be good to have some more info on that! |
Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks. |
I'm still able to reproduce this, the experience is still the same. If you edit a link and then click on submit the popup closes.
This is a post to track the comment made on this PR, I will remove the stale label and add a few others |
Currently the Link UI implementation in RichText (and possible in Nav block) is inconsistent in when it remains "open".
The Link UI only stays open if the URL is unchanged. If I make any edit to the URL and then click "submit", the whole popup closes.
Note this isn't a bug in the Link UI itself but more likely in how it is utilised in the specific components. Nonetheless it still manifest as "a problem with link editing".
@tellthemachines I wonder if you would elaborate more on the behaviour you would expect to see (based on your comment below)?
Ooooh. I didn't realise the popup was meant to stay open when clicking "submit". Testing locally with the latest changes in this branch, it only stays open if the URL is unchanged. If I make any edit to the URL and then click "submit", the whole popup closes.
Originally posted by @tellthemachines in #33849 (comment)
The text was updated successfully, but these errors were encountered: