Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link UI closing behaviour inconsistencies #35795

Open
getdave opened this issue Oct 20, 2021 · 3 comments
Open

Link UI closing behaviour inconsistencies #35795

getdave opened this issue Oct 20, 2021 · 3 comments
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Oct 20, 2021

Currently the Link UI implementation in RichText (and possible in Nav block) is inconsistent in when it remains "open".

The Link UI only stays open if the URL is unchanged. If I make any edit to the URL and then click "submit", the whole popup closes.

Note this isn't a bug in the Link UI itself but more likely in how it is utilised in the specific components. Nonetheless it still manifest as "a problem with link editing".

@tellthemachines I wonder if you would elaborate more on the behaviour you would expect to see (based on your comment below)?


Ooooh. I didn't realise the popup was meant to stay open when clicking "submit". Testing locally with the latest changes in this branch, it only stays open if the URL is unchanged. If I make any edit to the URL and then click "submit", the whole popup closes.

Originally posted by @tellthemachines in #33849 (comment)

@getdave getdave added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] Needs More Info Follow-up required in order to be actionable. labels Oct 20, 2021
@tellthemachines
Copy link
Contributor

I'd expect the behaviour to be consistent whether the URL is actually changed or not; my preference would be for it always closing when submit is clicked, but I'm not sure if it was implemented as it is for a reason, so would be good to have some more info on that!

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Help us move this issue forward. This issue is being marked stale since it has no activity after 15 days of requesting more information. Please add info requested so we can help move the issue forward. Note: The triage policy is to close stale issues that need more info and no response after 2 weeks.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 5, 2021
@getdave getdave removed the [Status] Needs More Info Follow-up required in order to be actionable. label Nov 5, 2021
@Thelmachido
Copy link

Thelmachido commented Sep 9, 2022

I'm still able to reproduce this, the experience is still the same. If you edit a link and then click on submit the popup closes.

  • WordPress 6.0.2
  • Gutenberg version 14.0.2
  • Twenty Twenty-Two theme

This is a post to track the comment made on this PR, I will remove the stale label and add a few others

@Thelmachido Thelmachido added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement. and removed [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants