Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real Button Block Component #36052

Open
deborah86 opened this issue Oct 28, 2021 · 2 comments
Open

Real Button Block Component #36052

deborah86 opened this issue Oct 28, 2021 · 2 comments
Labels
[Block] Buttons Affects the Buttons Block Needs Technical Feedback Needs testing from a developer perspective. [Type] Feature New feature to highlight in changelogs.

Comments

@deborah86
Copy link

What problem does this address?

The button block component is actually a link. This creates confusion with the development of blocks and block themes. It also makes it difficult for theme and block designers to incorporate html buttons into their designs.

What is your proposed solution?

There should be a separate component for HTML links and HTML buttons .

The link block should give the developer/user the ability to style it like a button. Instead of using the paragraph block in menus, the link block would be used instead.

The block component would be used to perform browser actions such as show/hide, search, post comment, etc.

These two steps are needed:

  1. Rebrand the button block to be designed link and add styles to show it as a button or a link. The link block should display as a text link when the user drags it onto the canvas to minimize the confusion between the two blocks. The user then has the ability to style the text links to look like buttons.
  2. Next, there would be the creation of the button block. The button block would replace the hard-coded buttons in form elements such as the button in the search form and the button in the comment form.

@deborah86
Copy link
Author

This is related to: Global Styles: Form elements #29167

@stevenlinx stevenlinx added [Block] Buttons Affects the Buttons Block [Type] Feature New feature to highlight in changelogs. Needs Technical Feedback Needs testing from a developer perspective. labels Nov 1, 2021
@robruiz
Copy link

robruiz commented Dec 28, 2023

I believe it's important to point out the fact that a button block does not provide a element in the generated markup currently. This is misleading and semantically incorrect. Bad for accessibility and SEO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Needs Technical Feedback Needs testing from a developer perspective. [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

No branches or pull requests

3 participants