Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated template part editor: Height doesn't always wrap correctly #36141

Closed
jameskoster opened this issue Nov 2, 2021 · 4 comments · Fixed by #37394
Closed

Isolated template part editor: Height doesn't always wrap correctly #36141

jameskoster opened this issue Nov 2, 2021 · 4 comments · Fixed by #37394
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

I noticed when testing with the Quadrat theme that the height of the header in the isolated template part editing view is not correct. For some reason it is way too tall:

edit-header.mp4

cc @kevin940726

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 2, 2021
@kevin940726
Copy link
Member

Yeah, sometimes it's tricky since the height could dynamically change at any time. I'll take a look at this.

@noisysocks
Copy link
Member

On tall viewports the height of the canvas is always too great. Would be good if we can make the canvas resize down to the intrinsic content size.

@noisysocks
Copy link
Member

More canvas height weirdness here: #37213 (comment)

@ntsekouras
Copy link
Contributor

This issues depend on each theme. For example in Quadrat there is this style.

.editor-styles-wrapper .wp-site-blocks { min-height: 100vh... } which makes the template part big. Could a simplistic solution of adding some styles like min-height: auto !important in the iframe (or by maybe first detecting such cases of vh) be enough? 🤔

The scrolling issues are related to this line and appear when we have height affecting styles to the root selector, which is the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants