Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing properties of a template part while editing a template can lead to confusing / unexpected results #36143

Closed
jameskoster opened this issue Nov 2, 2021 · 2 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Nov 2, 2021

Consider the flow: You're editing a template and decide to change your site header a bit. You update the colors and save. I think the expectation here is that those changes would be applied globally to the header. However, that is not the case – those changes are only applied to the header in the context of the template being edited, as can be revealed when you go to edit the header in isolation. This is best illustrated in a short video:

default.mp4

Enabling users to override the defaults in the context of the template like this no doubt has its uses, but I'm not sure it would be the expected default behaviour.

@jameskoster jameskoster added Needs Design Needs design efforts. [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 2, 2021
@carolinan
Copy link
Contributor

I believe this is the same as #30732?

@jameskoster
Copy link
Contributor Author

Right you are!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

2 participants