Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should be able to add a custom gradient when the default gradients are disabled #36640

Closed
oandregal opened this issue Nov 19, 2021 · 2 comments · Fixed by #36900
Closed
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

Description

The gradients panel doesn't allow user to add a custom gradient when the default gradients are disabled. The panel is empty but not hidden.

Step-by-step reproduction instructions

How to test

  • Use a theme that does not provide any solids or gradients.
  • Set defaultPalette and defaultGradients to false.

This is what I see for solids:

Captura de ecrã de 2021-11-19 10-44-14

This is what I see for gradients (note that it's empty):

Captura de ecrã de 2021-11-19 10-44-23

If I then disable the custom colors (settings.color.custom to false), this is what I see (the color panel is shown but it does not contain anything):

Captura de ecrã de 2021-11-19 10-48-23

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@oandregal oandregal added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended labels Nov 19, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 26, 2021
@andrewserong
Copy link
Contributor

I thought I'd start working on a fix for this one. I have a PR open in #36900, but I also noticed a couple of other issues with the gradient that I've raised in #36899. I'm just at the end of my week now, so I'll do some more investigating next week (I don't think it's related to my PR, but I'll do more testing next week to be sure).

@andrewserong
Copy link
Contributor

The main blocker in #36899 has been resolved, so the PR to fix the main issue here (ensure a custom gradient can be added when default and theme gradients are disabled) is ready for review now: #36900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants