Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin from template parts is not visible on select in the Site Editor #37106

Open
kjellr opened this issue Dec 3, 2021 · 2 comments
Open

Margin from template parts is not visible on select in the Site Editor #37106

kjellr opened this issue Dec 3, 2021 · 2 comments
Labels
[Block] Template Part Affects the Template Parts Block [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Dec 3, 2021

When the contents of a template part include margin, that margin is visible when you edit the template. Notice the whitespace shown to indicate the bottom margin here in Twenty Twenty-Two:

Screen Shot 2021-12-03 at 11 00 44 AM

When you're using the Site Editor though, it's unclear that the margin above is actually part of the template part. When I select the template part, the blue outline excludes the margin:

Screen Shot 2021-12-03 at 11 04 18 AM

This is a discoverability problem for users. If they'd like to edit that margin, it's hard for them to tell where it's coming from when using the Site Editor.

cc @jameskoster, I'm curious if you have thoughts here.

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block labels Dec 3, 2021
@jameskoster
Copy link
Contributor

Yeah this feels like a bug to me too. That margin should be visible when editing the template.

The rise of user-defined block paddings and margins also raises the value of something like #36437 as an aid to the discoverability issues you highlighted.

As a side-note, we touched on a similar problem earlier today in #36827 (starting around here). You may be interested in the conversation there.

@kjellr
Copy link
Contributor Author

kjellr commented Dec 3, 2021

Cool, thanks. We're having some parallel discussion here about whether we should be using Margin for this specific Twenty Twenty-Two use case anyway: #37105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants